Skip to content

Show time based on locale to support 12 hour and 24 hour notation in UI. #27133

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
wendigo merged 1 commit into from
Nov 20, 2025
Merged

Show time based on locale to support 12 hour and 24 hour notation in UI. #27133

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions core/trino-web-ui/src/main/resources/webapp-preview/src/utils/utils.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -319,9 +319,7 @@ export function parseDuration(value: string): number | null {
}

export function formatShortTime(date: Date): string {
const hours = date.getHours() % 12 || 12
const minutes = (date.getMinutes() < 10 ? '0' : '') + date.getMinutes()
return hours + ':' + minutes + (date.getHours() >= 12 ? 'pm' : 'am')
return date.toLocaleTimeString([], { timeStyle: 'short' })
}

export function formatShortDateTime(date: Date): string {
Expand Down
4 changes: 1 addition & 3 deletions core/trino-web-ui/src/main/resources/webapp/src/utils.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -501,9 +501,7 @@ export function parseDuration(value: string): ?number {
}

export function formatShortTime(date: Date): string {
const hours = date.getHours() % 12 || 12
const minutes = (date.getMinutes() < 10 ? '0' : '') + date.getMinutes()
return hours + ':' + minutes + (date.getHours() >= 12 ? 'pm' : 'am')
return date.toLocaleTimeString([], { timeStyle: 'short' }).replace(' ', '').toLowerCase()
}

export function formatShortDateTime(date: Date): string {
Expand Down