Merge pull request #847 from tronprotocol/useTxRawHash

Use tx raw hash

Author: wubin12

src/main/java/org/tron/core/capsule/BlockCapsule.java

@@ -239,7 +239,7 @@ public Sha256Hash calcMerkleRoot() {
 
     Vector<Sha256Hash> ids = transactionsList.stream()
         .map(TransactionCapsule::new)
-        .map(TransactionCapsule::getHash)
+        .map(TransactionCapsule::getMerkleHash)
         .collect(Collectors.toCollection(Vector::new));
 
     return MerkleTree.getInstance().createTree(ids).getRoot().getHash();

src/main/java/org/tron/core/capsule/TransactionCapsule.java

@@ -180,12 +180,12 @@ public void createTransaction(com.google.protobuf.Message message, ContractType
     transaction = Transaction.newBuilder().setRawData(transactionBuilder.build()).build();
   }
 
-  public Sha256Hash getHash() {
+  public Sha256Hash getMerkleHash() {
     byte[] transBytes = this.transaction.toByteArray();
     return Sha256Hash.of(transBytes);
   }
 
-  public Sha256Hash getRawHash() {
+  private Sha256Hash getRawHash() {
     return Sha256Hash.of(this.transaction.getRawData().toByteArray());
   }
 
@@ -363,7 +363,7 @@ public boolean validateSignature() throws ValidateSignatureException {
   }
 
   public Sha256Hash getTransactionId() {
-    return Sha256Hash.of(this.transaction.getRawData().toByteArray());
+    return getRawHash();
   }
 
   @Override

src/main/java/org/tron/core/db/api/index/TransactionIndex.java

@@ -1,26 +1,24 @@
 package org.tron.core.db.api.index;
 
+import static com.googlecode.cqengine.query.QueryFactory.attribute;
+
 import com.googlecode.cqengine.attribute.Attribute;
 import com.googlecode.cqengine.attribute.SimpleAttribute;
 import com.googlecode.cqengine.index.disk.DiskIndex;
 import com.googlecode.cqengine.persistence.disk.DiskPersistence;
+import java.util.Objects;
+import java.util.stream.Collectors;
+import javax.annotation.PostConstruct;
 import lombok.extern.slf4j.Slf4j;
 import org.springframework.beans.factory.annotation.Autowired;
 import org.springframework.beans.factory.annotation.Qualifier;
-import org.springframework.beans.factory.annotation.Value;
 import org.springframework.stereotype.Component;
 import org.tron.common.utils.ByteArray;
 import org.tron.core.capsule.TransactionCapsule;
 import org.tron.core.db.TronDatabase;
 import org.tron.core.db.common.WrappedByteArray;
 import org.tron.protos.Protocol.Transaction;
 
-import javax.annotation.PostConstruct;
-import java.util.Objects;
-import java.util.stream.Collectors;
-
-import static com.googlecode.cqengine.query.QueryFactory.attribute;
-
 @Component
 @Slf4j
 public class TransactionIndex extends AbstractIndex<TransactionCapsule, Transaction> {
@@ -49,7 +47,7 @@ public void init() {
   protected void setAttribute() {
     Transaction_ID =
         attribute("transaction id",
-            bytes -> new TransactionCapsule(getObject(bytes)).getRawHash().toString());
+            bytes -> new TransactionCapsule(getObject(bytes)).getTransactionId().toString());
     OWNERS =
         attribute(String.class, "owner address",
             bytes -> getObject(bytes).getRawData().getContractList().stream()

src/main/java/org/tron/core/net/message/TransactionMessage.java

@@ -1,5 +1,6 @@
 package org.tron.core.net.message;
 
+import org.tron.common.utils.Sha256Hash;
 import org.tron.core.capsule.TransactionCapsule;
 import org.tron.protos.Protocol;
 import org.tron.protos.Protocol.Transaction;
@@ -20,6 +21,11 @@ public TransactionMessage(Transaction trx) {
     this.data = trx.toByteArray();
   }
 
+  @Override
+  public Sha256Hash getMessageId() {
+    return getTransactionCapsule().getTransactionId();
+  }
+
   @Override
   public String toString() {
     return new StringBuilder().append(super.toString())

src/main/java/org/tron/core/net/node/NodeDelegateImpl.java

@@ -67,7 +67,7 @@ public synchronized LinkedList<Sha256Hash> handleBlock(BlockCapsule block, boole
         List<TransactionCapsule> trx = null;
         trx = block.getTransactions();
         return trx.stream()
-            .map(TransactionCapsule::getHash)
+            .map(TransactionCapsule::getTransactionId)
             .collect(Collectors.toCollection(LinkedList::new));
       } else {
         return null;