Add "--no-install-recommends", to prevent unwanted packages #653
Conversation
Add '--no-install-recommends', do not consider recommended packages as a dependency for installing. Only the required packages.
Add "--no-install-recommends" to the apt-get install specs
WalkthroughLinux installation path updated to add the apt-get flag --no-install-recommends after -y in Graphviz installation. Corresponding Linux test expectations were updated. No changes to macOS/Windows paths, apt-get update condition, or public APIs. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Poem
Tip 🔌 Remote MCP (Model Context Protocol) integration is now available!Pro plan users can now connect to remote MCP servers from the Integrations page. Connect with popular remote MCPs such as Notion and Linear to add more context to your reviews and chats. ✨ Finishing Touches
🧪 Generate unit tests
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. CodeRabbit Commands (Invoked using PR/Issue comments)Type Other keywords and placeholders
CodeRabbit Configuration File (
|
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @pv-rudger, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request introduces a modification to the Graphviz installation process by adding a specific flag to the apt-get install command. The primary goal of this change is to streamline installations by preventing the inclusion of unwanted or non-essential packages, thereby leading to a leaner and more controlled environment. The associated tests have also been updated to align with this new installation behavior.
Highlights
- Graphviz Installation Command Update: The
apt-get installcommand used for installing Graphviz now includes the--no-install-recommendsflag. This change aims to prevent the automatic installation of additional, often unnecessary, recommended packages. - Test Suite Alignment: Corresponding test cases in
src/__tests__/GraphvizInstaller.spec.tshave been updated to reflect the new installation command. This ensures that the tests accurately validate the behavior of theGraphvizInstallerclass with the added flag.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
|
/gemini review |
There was a problem hiding this comment.
Code Review
This pull request adds the --no-install-recommends flag to the apt-get install command, which is a good optimization to reduce installation size and time. The change is implemented correctly and the tests are updated accordingly. I've added one suggestion to make this new behavior configurable for increased flexibility. Overall, this is a valuable improvement.
There was a problem hiding this comment.
Code Review
This pull request adds the --no-install-recommends flag to the apt-get install command, which is a good practice to minimize the installation size on Ubuntu runners. The change is correct and the tests have been updated accordingly. I've added one suggestion to improve the code's readability by refactoring how the command arguments are constructed.
![coderabbitai[bot]](https://avatars.githubusercontent.com/in/347564?s=60&v=4){kind=small}
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (3)
src/GraphvizInstaller.ts (1)
39-50: Consider noninteractive installs to avoid rare CI hangsOccasionally, apt post-install scripts can prompt even with -y. Setting DEBIAN_FRONTEND=noninteractive for the install step hardens CI.
Apply this minimal change:
- await exec("sudo", [ + await exec("sudo", [ "apt-get", "install", "-y", "--no-install-recommends", … - ]); + ], { env: { ...process.env, DEBIAN_FRONTEND: "noninteractive" } });Optionally, if you want to avoid unintended upgrades during pinning, you could add
--no-upgradetoo:- "-y", - "--no-install-recommends", + "-y", + "--no-install-recommends", + "--no-upgrade",src/__tests__/GraphvizInstaller.spec.ts (2)
139-156: Reduce snapshot brittleness for apt args (optional)Inline snapshots of the entire arg list are a bit fragile. You could assert just the critical ordering of flags and then the presence of packages to make tests less noisy when package lists change.
Example pattern:
const installCall = execSpy.mock.calls.find( ([cmd, args]) => cmd === "sudo" && args[0] === "apt-get" && args[1] === "install", ); expect(installCall).toBeTruthy(); const [, aptArgs] = installCall!; expect(aptArgs.slice(0, 4)).toEqual(["apt-get", "install", "-y", "--no-install-recommends"]); expect(aptArgs).toEqual(expect.arrayContaining(["graphviz", "libgraphviz-dev", "pkg-config"]));
345-350: Typo in test name: “seted” → “set”Minor spelling fix for readability.
- test('graphviz version seted to "1.1.1"', async () => { + test('graphviz version set to "1.1.1"', async () => {
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
💡 Knowledge Base configuration:
- MCP integration is disabled by default for public repositories
- Jira integration is disabled by default for public repositories
- Linear integration is disabled by default for public repositories
You can enable these sources in your CodeRabbit configuration.
📒 Files selected for processing (2)
src/GraphvizInstaller.ts(1 hunks)src/__tests__/GraphvizInstaller.spec.ts(5 hunks)
🔇 Additional comments (3)
src/GraphvizInstaller.ts (2)
41-45: Add --no-install-recommends to apt-get install: LGTMThis is exactly the right place in the arg order (options before packages). It will keep the runner leaner and reduce surprise dependencies.
39-50: All apt-get installs include --no-install-recommendsRan the repo-wide search for any
exec("sudo", ["apt-get", "install", "-y", …])calls missing the--no-install-recommendsflag and found no additional instances.src/__tests__/GraphvizInstaller.spec.ts (1)
147-151: Linux inline snapshots updated to include --no-install-recommends: LGTMAll Linux paths now assert the presence of the new flag immediately after -y, consistent with the implementation.
Also applies to: 179-183, 220-224, 259-263, 298-302
1 participant
Summary by CodeRabbit