[codec] prometheus : initial implementation of prometheus wire codec #244
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
|
Please fix lint issues: https://github.com/tsaikd/gogstash/actions/runs/14107953286/job/39518884619?pr=244 |
Contributor
Author
|
Lint issues fixed, as requested. |
tsaikd
reviewed
Mar 29, 2025
tsaikd
reviewed
Apr 1, 2025
tsaikd
reviewed
Apr 1, 2025
| // Decode lines, every metric is an possible individual event | ||
| { | ||
| e := event | ||
| err = c.decodePrometheusEvent(line, savetype, &e) |
Owner
There was a problem hiding this comment.
e1 := logevent.LogEvent{
Extra: map[string]any{
"foo": "bar",
},
}
e2 := e1
e2.Extra["foo"] = "omg" // e1.Extra["foo"] is also assigned to "omg"Is it what you want?
Contributor
Author
There was a problem hiding this comment.
It's supposed to be a copy, not a reference. Rather than iteratively instantiating logevent.LogEvent{} objects, I was just trying to copy them and then modify then with the actual events.
Co-authored-by: Tsai KD <tsaikd@gmail.com>
tsaikd
reviewed
Apr 2, 2025
| if err == nil { | ||
| select { | ||
| case <-ctx.Done(): | ||
| // error handling ... |
Owner
There was a problem hiding this comment.
Do you want to continue processing when ctx has been canceled?
Contributor
Author
There was a problem hiding this comment.
Probably not, since it would indicate the connection being closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.