Skip to content

Conversation

@fquiroz01
Copy link

When you have limit=5, 3 results length for suggestions and 0 rendered, for example, then you only render 2 results.
because
rendered += suggestions.length; // 0+=3; rendered= 3
that._append(query, suggestions.slice(0, 5 - 3)); // that._append(query, suggestions.slice(0, 2));

When the lines are swape
that._append(query, suggestions.slice(0, 5 - 0)); // that._append(query, suggestions.slice(0, 5));
rendered += suggestions.length; // 0+=3; rendered= 3

When you have limit=5, 3 results length for suggestions and 0 rendered, for example, then you only render 2 results.
because 
rendered += suggestions.length; // 0+=3; rendered= 3
that._append(query, suggestions.slice(0, 5 - 3)); // that._append(query, suggestions.slice(0, 2));

When the lines are swape
that._append(query, suggestions.slice(0, 5 - 0)); // that._append(query, suggestions.slice(0, 5));
rendered += suggestions.length; // 0+=3; rendered= 3
@androzd
Copy link

androzd commented Sep 18, 2017

dist not rebuilded

@CLAassistant
Copy link

CLAassistant commented Jul 18, 2019

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

3 participants