Skip to content

Run tests against Java 25 #4493

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: series/3.x
Choose a base branch
from
Draft

Run tests against Java 25 #4493

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 26 additions & 26 deletions .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -37,28 +37,28 @@ jobs:
- temurin@8
- temurin@11
- temurin@17
- temurin@21
- temurin@25
- graalvm@21
ci: [ciJVM, ciNative, ciJS, ciFirefox, ciChrome]
exclude:
- scala: 3.3.5
java: temurin@11
- scala: 3.3.5
java: temurin@21
java: temurin@25
- scala: 2.12.20
java: temurin@11
- scala: 2.12.20
java: temurin@17
- scala: 2.12.20
java: temurin@21
java: temurin@25
- scala: 2.12.20
java: graalvm@21
- os: ubuntu-22.04-arm
java: temurin@8
- os: ubuntu-22.04-arm
java: temurin@11
- os: ubuntu-22.04-arm
java: temurin@21
java: temurin@25
- os: ubuntu-22.04-arm
java: graalvm@21
- os: windows-latest
Expand Down Expand Up @@ -90,7 +90,7 @@ jobs:
- ci: ciJS
java: temurin@17
- ci: ciJS
java: temurin@21
java: temurin@25
- ci: ciJS
java: graalvm@21
- os: ubuntu-22.04-arm
Expand All @@ -104,7 +104,7 @@ jobs:
- ci: ciFirefox
java: temurin@17
- ci: ciFirefox
java: temurin@21
java: temurin@25
- ci: ciFirefox
java: graalvm@21
- os: ubuntu-22.04-arm
Expand All @@ -118,7 +118,7 @@ jobs:
- ci: ciChrome
java: temurin@17
- ci: ciChrome
java: temurin@21
java: temurin@25
- ci: ciChrome
java: graalvm@21
- os: ubuntu-22.04-arm
Expand Down Expand Up @@ -146,16 +146,16 @@ jobs:
java: temurin@17
os: windows-latest
- ci: ciNative
java: temurin@21
java: temurin@25
os: ubuntu-latest
- ci: ciNative
java: temurin@21
java: temurin@25
os: ubuntu-22.04-arm
- ci: ciNative
java: temurin@21
java: temurin@25
os: windows-latest
- ci: ciNative
java: temurin@21
java: temurin@25
os: macos-14
- ci: ciNative
java: graalvm@21
Expand Down Expand Up @@ -235,17 +235,17 @@ jobs:
shell: bash
run: sbt +update

- name: Setup Java (temurin@21)
id: setup-java-temurin-21
if: matrix.java == 'temurin@21'
- name: Setup Java (temurin@25)
id: setup-java-temurin-25
if: matrix.java == 'temurin@25'
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: 21
java-version: 25
cache: sbt

- name: sbt update
if: matrix.java == 'temurin@21' && steps.setup-java-temurin-21.outputs.cache-hit == 'false'
if: matrix.java == 'temurin@25' && steps.setup-java-temurin-25.outputs.cache-hit == 'false'
shell: bash
run: sbt +update

Expand Down Expand Up @@ -413,17 +413,17 @@ jobs:
if: matrix.java == 'temurin@17' && steps.setup-java-temurin-17.outputs.cache-hit == 'false'
run: sbt +update

- name: Setup Java (temurin@21)
id: setup-java-temurin-21
if: matrix.java == 'temurin@21'
- name: Setup Java (temurin@25)
id: setup-java-temurin-25
if: matrix.java == 'temurin@25'
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: 21
java-version: 25
cache: sbt

- name: sbt update
if: matrix.java == 'temurin@21' && steps.setup-java-temurin-21.outputs.cache-hit == 'false'
if: matrix.java == 'temurin@25' && steps.setup-java-temurin-25.outputs.cache-hit == 'false'
run: sbt +update

- name: Setup Java (graalvm@21)
Expand Down Expand Up @@ -641,17 +641,17 @@ jobs:
if: matrix.java == 'temurin@17' && steps.setup-java-temurin-17.outputs.cache-hit == 'false'
run: sbt +update

- name: Setup Java (temurin@21)
id: setup-java-temurin-21
if: matrix.java == 'temurin@21'
- name: Setup Java (temurin@25)
id: setup-java-temurin-25
if: matrix.java == 'temurin@25'
uses: actions/setup-java@v4
with:
distribution: temurin
java-version: 21
java-version: 25
cache: sbt

- name: sbt update
if: matrix.java == 'temurin@21' && steps.setup-java-temurin-21.outputs.cache-hit == 'false'
if: matrix.java == 'temurin@25' && steps.setup-java-temurin-25.outputs.cache-hit == 'false'
run: sbt +update

- name: Setup Java (graalvm@21)
Expand Down
2 changes: 1 addition & 1 deletion build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -138,7 +138,7 @@ ThisBuild / githubWorkflowPublishPreamble +=
val OldGuardJava = JavaSpec.temurin("8")
val LTSJava = JavaSpec.temurin("11")
val LatestJava = JavaSpec.temurin("17")
val LoomJava = JavaSpec.temurin("21")
val LoomJava = JavaSpec.temurin("25")
Comment on lines 140 to +141
Copy link
Contributor Author

@iRevive iRevive Oct 1, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we merge LatestJava and LoomJava?

Copy link
Member

@armanbilge armanbilge Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not entirely sure what you mean by "merge", but I think we should add 25 without dropping 21 or 17.

  • 21 is still in the 8 year LTS period
  • Although 17 has exited the 8 year LTS period, Scala 3.8 LTS has chosen to target Java 17 as its minimum version, so IMO it is still a significant version to test against

Copy link
Contributor

@mzuehlke mzuehlke Oct 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we don't want to further increase the size of the build matrix, in my opinion Java 11 is the least important version.

Copy link
Contributor Author

@iRevive iRevive Oct 5, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Currently we have:

  • 8 - EOL 2030 - should remain as long as we support Java 8
  • 11 - EOL 2032
  • 17 - EOL 2029 - minimum version for upcoming Scala 3.8 LTS
  • 21 - EOL 2031 - Loom release
  • 25 - EOL 2033 - new LTS/most recent version

Java 11 is a good candidate to drop.

val ScalaJSJava = OldGuardJava
val ScalaNativeJava = OldGuardJava
val GraalVM = JavaSpec.graalvm("21")
Expand Down
Loading