From 11a020dffc559839ce1b1e2850f4ad3a25537890 Mon Sep 17 00:00:00 2001 From: lukehollestelle Date: Wed, 19 Jan 2022 18:43:12 -0800 Subject: [PATCH 1/5] new file that breaks the code Exception in thread "main" java.lang.StringIndexOutOfBoundsException: begin 0, end -1, length 8 at java.base/java.lang.String.checkBoundsBeginEnd(String.java:4601) at java.base/java.lang.String.substring(String.java:2704) at MarkdownParse.getLinks(MarkdownParse.java:18) at MarkdownParse.main(MarkdownParse.java:27) --- MarkdownParse.java | 1 + break-file.md | 1 + 2 files changed, 2 insertions(+) create mode 100644 break-file.md diff --git a/MarkdownParse.java b/MarkdownParse.java index 0534f8140..66be5226e 100644 --- a/MarkdownParse.java +++ b/MarkdownParse.java @@ -17,6 +17,7 @@ public static ArrayList getLinks(String markdown) { int closeParen = markdown.indexOf(")", openParen); toReturn.add(markdown.substring(openParen + 1, closeParen)); currentIndex = closeParen + 1; + System.out.println(currentIndex); } return toReturn; } diff --git a/break-file.md b/break-file.md new file mode 100644 index 000000000..a97387455 --- /dev/null +++ b/break-file.md @@ -0,0 +1 @@ +# Title From 9dd8c0f0e50c8a111946ca96803564b0db88e294 Mon Sep 17 00:00:00 2001 From: lukehollestelle Date: Wed, 19 Jan 2022 18:59:27 -0800 Subject: [PATCH 2/5] Update MarkdownParse.java --- MarkdownParse.java | 3 +++ 1 file changed, 3 insertions(+) diff --git a/MarkdownParse.java b/MarkdownParse.java index 66be5226e..9b49fe2da 100644 --- a/MarkdownParse.java +++ b/MarkdownParse.java @@ -15,6 +15,9 @@ public static ArrayList getLinks(String markdown) { int nextCloseBracket = markdown.indexOf("]", nextOpenBracket); int openParen = markdown.indexOf("(", nextCloseBracket); int closeParen = markdown.indexOf(")", openParen); + if(nextOpenBracket == -1 || nextCloseBracket == -1 || openParen == -1 || closeParen == -1){ + return toReturn; + } toReturn.add(markdown.substring(openParen + 1, closeParen)); currentIndex = closeParen + 1; System.out.println(currentIndex); From 1580c21cb6e82ca455ebfa412fcd92529685d7f0 Mon Sep 17 00:00:00 2001 From: lukehollestelle Date: Wed, 19 Jan 2022 19:11:10 -0800 Subject: [PATCH 3/5] file that breaks the code and updated code fixes when text is in between the brackets and parenthesis --- MarkdownParse.java | 4 +++- break-file2.md | 3 +++ 2 files changed, 6 insertions(+), 1 deletion(-) create mode 100644 break-file2.md diff --git a/MarkdownParse.java b/MarkdownParse.java index 9b49fe2da..c0dfaa853 100644 --- a/MarkdownParse.java +++ b/MarkdownParse.java @@ -18,7 +18,9 @@ public static ArrayList getLinks(String markdown) { if(nextOpenBracket == -1 || nextCloseBracket == -1 || openParen == -1 || closeParen == -1){ return toReturn; } - toReturn.add(markdown.substring(openParen + 1, closeParen)); + if(openParen == nextCloseBracket + 1){ + toReturn.add(markdown.substring(openParen + 1, closeParen)); + } currentIndex = closeParen + 1; System.out.println(currentIndex); } diff --git a/break-file2.md b/break-file2.md new file mode 100644 index 000000000..89c341252 --- /dev/null +++ b/break-file2.md @@ -0,0 +1,3 @@ +[example] +extra text to mess it up +(some-page.html) \ No newline at end of file From 835401287d93a5fce4ec6ca951853fa83685c89f Mon Sep 17 00:00:00 2001 From: lukehollestelle Date: Thu, 27 Jan 2022 16:11:08 -0800 Subject: [PATCH 4/5] Revert "file that breaks the code and updated code" This reverts commit 1580c21cb6e82ca455ebfa412fcd92529685d7f0. --- MarkdownParse.java | 4 +--- MarkdownParseTest.java | 0 break-file2.md | 3 --- 3 files changed, 1 insertion(+), 6 deletions(-) create mode 100644 MarkdownParseTest.java delete mode 100644 break-file2.md diff --git a/MarkdownParse.java b/MarkdownParse.java index c0dfaa853..9b49fe2da 100644 --- a/MarkdownParse.java +++ b/MarkdownParse.java @@ -18,9 +18,7 @@ public static ArrayList getLinks(String markdown) { if(nextOpenBracket == -1 || nextCloseBracket == -1 || openParen == -1 || closeParen == -1){ return toReturn; } - if(openParen == nextCloseBracket + 1){ - toReturn.add(markdown.substring(openParen + 1, closeParen)); - } + toReturn.add(markdown.substring(openParen + 1, closeParen)); currentIndex = closeParen + 1; System.out.println(currentIndex); } diff --git a/MarkdownParseTest.java b/MarkdownParseTest.java new file mode 100644 index 000000000..e69de29bb diff --git a/break-file2.md b/break-file2.md deleted file mode 100644 index 89c341252..000000000 --- a/break-file2.md +++ /dev/null @@ -1,3 +0,0 @@ -[example] -extra text to mess it up -(some-page.html) \ No newline at end of file From 81cc4534106963dd5866b79a202f0d62090036c2 Mon Sep 17 00:00:00 2001 From: lukehollestelle Date: Thu, 27 Jan 2022 16:33:13 -0800 Subject: [PATCH 5/5] Create break-file2.md --- break-file2.md | 3 +++ 1 file changed, 3 insertions(+) create mode 100644 break-file2.md diff --git a/break-file2.md b/break-file2.md new file mode 100644 index 000000000..89c341252 --- /dev/null +++ b/break-file2.md @@ -0,0 +1,3 @@ +[example] +extra text to mess it up +(some-page.html) \ No newline at end of file