Fixes #410 - Add support for metadata-only display to collection level record view

Fixes hound issue

Fixes indentation

Fixes hound violation

Use alternative way to check for metadataonly collection

Author: VivianChu

.rubocop.yml

@@ -33,3 +33,6 @@ Style/Next:
 
 Metrics/AbcSize:
   Max: 50
+
+Metrics/LineLength:
+  Max: 150

app/controllers/dams_resource_controller.rb

@@ -40,6 +40,10 @@ def show
     # generate facet collection list for collection page only
     models = @document["active_fedora_model_ssi"]
     if models.include?("DamsAssembledCollection") || models.include?("DamsProvenanceCollection") || models.include?("DamsProvenanceCollectionPart") 
+      other_rights_query = "(otherRights_tesim:localDisplay OR otherRights_tesim:metadataDisplay) AND collections_tesim:#{params[:id]}"
+      @res, @doc = get_search_results(q: other_rights_query, rows: 1)
+      @metadata_only = !@res.response['numFound'].zero?
+
         facet_collection_params = { :f=>{"collection_sim"=>"#{@document['title_tesim'].first.to_s}"}, :id=>params[:id], :rows => 0 }
         apply_gated_discovery( facet_collection_params, nil )
         @facet_collection_resp = get_search_results( facet_collection_params )

app/views/shared/fields/_access_control_level.html.erb

@@ -7,14 +7,16 @@
 	if accessGroup != nil
 
 		if accessGroup.include?('public')
-		  viewAccess = nil
-	  elsif accessGroup.include?('local')
+		    viewAccess = :public
+	        elsif accessGroup.include?('local') && @metadata_only
+		    viewAccess = 'Restricted View'		  
+	        elsif accessGroup.include?('local')
 		    viewAccess = 'Restricted to UC San Diego use only'
 		else
-		  viewAccess = 'Curator Only'
+		    viewAccess = 'Curator Only'
 		end
 
-		if viewAccess != nil
+		if viewAccess != :public
 			htmlOpen %= 'Access'
 			concat htmlOpen.html_safe
 			concat "<li>#{viewAccess}</li>".html_safe

spec/features/dams_collections_spec.rb

@@ -341,3 +341,53 @@
   end
 
 end
+
+
+feature "Visitor wants to view a UCSD IP only collection's page with metadata-only visibility" do
+  before(:all) do
+    @localDisplay = DamsOtherRight.create permissionType: "localDisplay"
+    @metadataDisplay = DamsOtherRight.create permissionType: "metadataDisplay"
+    @metadataOnlyCollection = DamsProvenanceCollection.create titleValue: "Test UCSD IP only Collection with metadata-only visibility", visibility: "local"    
+    @localOnlyCollection = DamsProvenanceCollection.create titleValue: "Test UCSD IP only Collection with localDisplay visibility", visibility: "local"    
+    @collection = DamsProvenanceCollection.create titleValue: "Test UCSD IP only Collection with no localDisplay or metadata-only visibility", visibility: "local"    
+    @copyright = DamsCopyright.create status: 'Under copyright'
+    @metadataOnlyObj = DamsObject.create titleValue: 'Test Object with metadataOnly Display', provenanceCollectionURI: @metadataOnlyCollection.pid, copyrightURI: @copyright.pid, otherRightsURI: @metadataDisplay.pid
+    @localObj = DamsObject.create titleValue: 'Test Object with localDisplay', provenanceCollectionURI: @localOnlyCollection.pid, copyrightURI: @copyright.pid, otherRightsURI: @localDisplay.pid
+    @obj = DamsObject.create titleValue: 'Test Object with no localDisplay, no metadataOnlyDisplay', provenanceCollectionURI: @localOnlyCollection.pid, copyrightURI: @copyright.pid
+    solr_index @localDisplay.pid
+    solr_index @metadataDisplay.pid
+    solr_index @metadataOnlyCollection.pid
+    solr_index @localOnlyCollection.pid
+    solr_index @collection.pid       
+    solr_index @copyright.pid
+    solr_index @metadataOnlyObj.pid
+    solr_index @localObj.pid
+    solr_index @obj.pid
+  end
+
+  after(:all) do
+    @localDisplay.delete
+    @metadataDisplay.delete
+    @metadataOnlyCollection.delete
+    @localOnlyCollection.delete
+    @collection.delete   
+    @copyright.delete
+    @metadataOnlyObj.delete
+    @localObj.delete
+    @obj.delete
+  end
+
+  scenario 'should see Restricted View access control information' do
+    sign_in_anonymous '132.239.0.3'
+    visit dams_collection_path @metadataOnlyCollection.pid
+    expect(page).to have_content('Restricted View')
+    visit dams_collection_path @localOnlyCollection.pid
+    expect(page).to have_content('Restricted View')
+  end
+
+  scenario 'should not see Restricted View access control information' do
+    sign_in_anonymous '132.239.0.3'
+    visit dams_collection_path @collection.pid
+    expect(page).to_not have_content('Restricted View')
+  end
+end