Add title attribute to image tag

Author: VivianChu

app/assets/javascripts/views-object.js

@@ -123,7 +123,7 @@ dp.cartographics = {}; // CARTOGRAPHICS DISPLAY
 				switch(fileType)
 				{
 					case "image":
-            $(container).html( '<a href="'+serviceFilePath+'" alt=""><img alt="' + alt_txt + '" src="'+displayFilePath+'"></a>' );
+            $(container).html( '<a href="'+serviceFilePath+'" alt=""><img alt="' + alt_txt + '" title="' + alt_txt + '" src="'+displayFilePath+'"></a>' );
 						break;
 					case "audio":
                         jwplayer("dams-audio-"+componentIndex).setup({

app/views/dams_collections/show.html.erb

@@ -46,7 +46,7 @@
     <div class="hidden-phone">
       <%# Collection image %>
       <div id="collections-image" class="hidden-phone">
-        <img src="/assets/dams/collections/img/<%=@document['id']%>.jpg" alt="<%=alt_tag_text(@collection_title)%>">
+        <img src="/assets/dams/collections/img/<%=@document['id']%>.jpg" alt="<%=alt_tag_text(@collection_title)%>" title="<%=alt_tag_text(@collection_title)%>">
       </div>
       <%# Collection controls %>
       <% if @object_count > 0 %>

app/views/dams_objects/_image_viewer.html.erb

@@ -7,18 +7,18 @@
    alt_txt = alt_tag_text(@page_title)
 %>
 <% if displayFilePath.length > 0 && getFilesType != "PDF"%>
-   <%= link_to image_tag(displayFilePath, :alt => "#{alt_txt}"), zoomFilePath %>
+   <%= link_to image_tag(displayFilePath, :alt => "#{alt_txt}", :title => "#{alt_txt}"), zoomFilePath %>
 <% else %>
 	<% if getFilesType == "PDF" %>
 		<% if displayFilePath.to_s == ''%> 
 			<%= render :partial => 'metadata_data_file', :locals => {:fileName => filePath} %>
 		<% else %>
-				<%= link_to image_tag(displayFilePath, :alt => "#{alt_txt}"), zoomFilePath %>
+				<%= link_to image_tag(displayFilePath, :alt => "#{alt_txt}", :title => "#{alt_txt}"), zoomFilePath %>
 			<%= render :partial => 'metadata_data_file', :locals => {:fileName => service_file} %>
 		<% end %>
 		<%= render :partial => 'data_viewer', :locals => {:filePath => pdfFilePath, :objectType => 'simple', :displayFilePath => displayFilePath} %>
 	<% else %>
-		<%= link_to image_tag(filePath, :alt => "#{alt_txt}"), zoomFilePath %>
+		<%= link_to image_tag(filePath, :alt => "#{alt_txt}", :title => "#{alt_txt}"), zoomFilePath %>
 	<% end %>
 <% end %>
 <%= render :partial => 'admin_download', :locals => {:embedURL => embed_url, :downloadFilePath => downloadFilePath, :downloadDerivativePath => downloadDerivativePath, :format => file_type} %>

spec/features/dams_collections_spec.rb

@@ -182,6 +182,11 @@
     expect(page).to have_selector("#collections-image img")
     expect(find("#collections-image img")['alt']).to eq('Heavy Metals in the Ocean Insect, Halobates')
   end
+  
+  scenario 'PAGE SHOULD HAVE COLLECTION IMAGE TITLE ATTRIBUTE IN DESKTOP VIEW' do
+    visit dams_collection_path("#{@provCollection.pid}")
+    expect(find("#collections-image img")['title']).to eq('Heavy Metals in the Ocean Insect, Halobates')
+  end
 end
 
 #---

spec/features/dams_object_spec.rb

@@ -1645,6 +1645,7 @@
 
 describe "User wants to view an Image object" do
   before(:all) do
+    @truncate_title = 'Object Files Test Object Files Test Object Files Test Object Files Test Object Files Test Object Files Test Object Files T...'
     @long_title = 'Object Files Test Object Files Test Object Files Test Object Files Test Object Files Test Object Files Test Object Files Test Object Files Test'
     @col = DamsAssembledCollection.create( titleValue: 'Test Collection', visibility: 'public' )
     @obj = DamsObject.create( titleValue: @long_title, copyright_attributes: [ {status: 'Public domain'} ],
@@ -1671,10 +1672,11 @@
       expect(page.body).to match(/embed\/#{@obj.id}\/0/)
     end
   end
-  scenario 'have image alt text' do
+  scenario 'have image alt text and title' do
     sign_in_developer
     visit dams_object_path @obj.pid
-    expect(find("div.simple-object a img")['alt']).to eq('Object Files Test Object Files Test Object Files Test Object Files Test Object Files Test Object Files Test Object Files T...')
+    expect(find("div.simple-object a img")['alt']).to eq(@truncate_title)
+    expect(find("div.simple-object a img")['title']).to eq(@truncate_title)
   end
 end