Fixes #111 by wrapping nested ConvertDbToString and ConvertDbToEditor calls in a try catch

Author: mattbrailsford

src/Our.Umbraco.NestedContent/PropertyEditors/NestedContentPropertyEditor.cs

@@ -1,4 +1,5 @@
-using System.Collections.Generic;
+using System;
+using System.Collections.Generic;
 using System.ComponentModel.DataAnnotations;
 using System.Linq;
 using System.Text.RegularExpressions;
@@ -160,15 +161,26 @@ public override string ConvertDbToString(Property property, PropertyType propert
                         }
                         else
                         {
-                            // Create a fake property using the property abd stored value
-                            var prop = new Property(propType, propValues[propKey] == null ? null : propValues[propKey].ToString());
+                            try
+                            {
+                                // Create a fake property using the property abd stored value
+                                var prop = new Property(propType, propValues[propKey] == null ? null : propValues[propKey].ToString());
 
-                            // Lookup the property editor
-                            var propEditor = PropertyEditorResolver.Current.GetByAlias(propType.PropertyEditorAlias);
+                                // Lookup the property editor
+                                var propEditor = PropertyEditorResolver.Current.GetByAlias(propType.PropertyEditorAlias);
 
-                            // Get the editor to do it's conversion, and store it back
-                            propValues[propKey] = propEditor.ValueEditor.ConvertDbToString(prop, propType,
-                                ApplicationContext.Current.Services.DataTypeService);
+                                // Get the editor to do it's conversion, and store it back
+                                propValues[propKey] = propEditor.ValueEditor.ConvertDbToString(prop, propType,
+                                    ApplicationContext.Current.Services.DataTypeService);
+                            }
+                            catch (InvalidOperationException)
+                            {
+                                // https://github.com/umco/umbraco-nested-content/issues/111
+                                // Catch any invalid cast operations as likely means courier failed due to missing
+                                // or trashed item so couldn't convert a guid back to an int
+
+                                propValues[propKey] = null;
+                            }
                         }
 
                     }
@@ -225,18 +237,29 @@ public override object ConvertDbToEditor(Property property, PropertyType propert
                         }
                         else
                         {
-                            // Create a fake property using the property abd stored value
-                            var prop = new Property(propType, propValues[propKey] == null ? null : propValues[propKey].ToString());
+                            try
+                            {
+                                // Create a fake property using the property abd stored value
+                                var prop = new Property(propType, propValues[propKey] == null ? null : propValues[propKey].ToString());
 
-                            // Lookup the property editor
-                            var propEditor = PropertyEditorResolver.Current.GetByAlias(propType.PropertyEditorAlias);
+                                // Lookup the property editor
+                                var propEditor = PropertyEditorResolver.Current.GetByAlias(propType.PropertyEditorAlias);
 
-                            // Get the editor to do it's conversion
-                            var newValue = propEditor.ValueEditor.ConvertDbToEditor(prop, propType,
-                                ApplicationContext.Current.Services.DataTypeService);
+                                // Get the editor to do it's conversion
+                                var newValue = propEditor.ValueEditor.ConvertDbToEditor(prop, propType,
+                                    ApplicationContext.Current.Services.DataTypeService);
 
-                            // Store the value back
-                            propValues[propKey] = (newValue == null) ? null : JToken.FromObject(newValue);
+                                // Store the value back
+                                propValues[propKey] = (newValue == null) ? null : JToken.FromObject(newValue);
+                            }
+                            catch (InvalidOperationException)
+                            {
+                                // https://github.com/umco/umbraco-nested-content/issues/111
+                                // Catch any invalid cast operations as likely means courier failed due to missing
+                                // or trashed item so couldn't convert a guid back to an int
+
+                                propValues[propKey] = null;
+                            }
                         }
 
                     }