Skip to content

Commit 81949a5

Browse files
authored
Merge pull request #7 from unifio/yl-wip
Terraform 0.7.x compatibility updates
2 parents cefa679 + fa1045b commit 81949a5

File tree

5 files changed

+13
-10
lines changed

5 files changed

+13
-10
lines changed

CHANGELOG.md

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -7,6 +7,13 @@
77
- Fix the 4 subnet fixed mapping
88
- Fill in some examples
99

10+
## 0.0.8
11+
12+
#### IMPROVEMENTS:
13+
- [#6]: (certs) - Simplify logic when specifying a custom ami.
14+
- [#7]: (generate-certs) - Terraform 0.7.x compatibility updates.
15+
- [#7]: (certs) - Terraform 0.7.x compatibility updates.
16+
1017
## 0.0.7
1118

1219
#### BUG FIXES:

Rakefile

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -21,7 +21,7 @@ task :verify do
2121

2222
vars = []
2323
inputs.each() do |var, value|
24-
vars.push("-var #{var}=\"#{value}\"")
24+
vars.push("-var '#{var}=\"#{value}\"'")
2525
end
2626

2727
['server','cert-gen'].each do |stack|

certs/main.tf

Lines changed: 2 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -184,7 +184,7 @@ resource "aws_security_group_rule" "cluster_allow_icmp_in" {
184184
}
185185

186186
## Creates instance user data
187-
resource "template_file" "user_data" {
187+
data "template_file" "user_data" {
188188
template = "${file("${path.module}/templates/user_data.tpl")}"
189189

190190
vars {
@@ -193,10 +193,6 @@ resource "template_file" "user_data" {
193193
s3_bucket_prefix = "${var.s3_bucket_prefix}"
194194
route_cidrs = "${var.route_cidrs}"
195195
}
196-
197-
lifecycle {
198-
create_before_destroy = true
199-
}
200196
}
201197

202198
## Creates auto scaling cluster
@@ -216,7 +212,7 @@ module "cluster" {
216212
ami = "${coalesce(var.ami_custom, lookup(var.ami_region_lookup, var.region))}"
217213
instance_type = "${var.instance_type}"
218214
instance_profile = "${aws_iam_instance_profile.profile.id}"
219-
user_data = "${template_file.user_data.rendered}"
215+
user_data = "${data.template_file.user_data.rendered}"
220216
key_name = "${var.key_name}"
221217
ebs_optimized = false
222218

circle.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
machine:
22
environment:
3-
TF_VERSION: 0.6.16
3+
TF_VERSION: 0.7.4
44
TF_URL: https://releases.hashicorp.com/terraform/${TF_VERSION}/terraform_${TF_VERSION}_linux_amd64.zip
55
dependencies:
66
pre:

generate-certs/main.tf

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -115,7 +115,7 @@ resource "aws_security_group_rule" "allow_ssh_in" {
115115
}
116116

117117
## Creates user instance data
118-
resource "template_file" "user_data" {
118+
data "template_file" "user_data" {
119119
template = "${file("${path.module}/templates/user_data.tpl")}"
120120

121121
vars {
@@ -155,5 +155,5 @@ resource "aws_instance" "generate_certs" {
155155
managed_by = "terraform"
156156
}
157157

158-
user_data = "${template_file.user_data.rendered}"
158+
user_data = "${data.template_file.user_data.rendered}"
159159
}

0 commit comments

Comments
 (0)