fix array out of index, if removed last recent project item from list, display error message if try to launch from explorer (without any unity editors) #212

Author: unitycoder

UnityLauncherPro/Tools.cs

@@ -274,6 +274,13 @@ public static Process LaunchProject(Project proj, DataGrid dataGridRef = null, b
             var unityExePath = GetUnityExePath(proj.Version);
             if (unityExePath == null)
             {
+                // if no editors installed, show message
+                if (MainWindow.unityInstallationsSource.Count == 0)
+                {
+                    MessageBox.Show($"No Unity versions installed. Please run {MainWindow.appName} first to setup root folders.", MainWindow.appName, MessageBoxButton.OK, MessageBoxImage.Warning);
+                    return null;
+                }
+
                 DisplayUpgradeDialog(proj, null, useInitScript);
                 return null;
             }
@@ -1665,6 +1672,9 @@ public static void SetFocusToGrid(DataGrid targetGrid, int index = -1)
             DataGridRow row = (DataGridRow)targetGrid.ItemContainerGenerator.ContainerFromIndex(index);
             if (row == null)
             {
+                // clamp to max items
+                if (index >= targetGrid.Items.Count) index = targetGrid.Items.Count - 1;
+
                 targetGrid.ScrollIntoView(targetGrid.Items[index]);
                 // Defer the focus once row is generated
                 targetGrid.Dispatcher.InvokeAsync(() =>

UnityLauncherPro/UpgradeWindow.xaml.cs

@@ -26,11 +26,6 @@ public UpgradeWindow(string currentVersion, string projectPath, string commandLi
 
             gridAvailableVersions.SelectedItem = null;
 
-            // we have current version info in project
-            // enable release and dl buttons
-            btnOpenReleasePage.IsEnabled = true;
-            btnDownload.IsEnabled = true;
-
             // if dont have exact version, show red outline
             if (currentVersion == null || MainWindow.unityInstalledVersions.ContainsKey(currentVersion) == false)
             {
@@ -40,6 +35,10 @@ public UpgradeWindow(string currentVersion, string projectPath, string commandLi
 
             if (currentVersion != null)
             {
+                // we know the version, enable buttons
+                btnOpenReleasePage.IsEnabled = true;
+                btnDownload.IsEnabled = true;
+
                 // remove china c1 from version
                 if (currentVersion.Contains("c")) currentVersion = currentVersion.Replace("c1", "");
                 // find nearest version
@@ -150,6 +149,13 @@ private void GridAvailableVersions_PreviewMouseDoubleClick(object sender, MouseB
         void Upgrade()
         {
             var k = (UnityInstallation)gridAvailableVersions.SelectedItem;
+
+            if (k == null)
+            {
+                DialogResult = false;
+                return;
+            }
+
             upgradeVersion = k.Version;
             DialogResult = true;
         }