Skip to content

Commit fa5e841

Browse files
committed
Fix pr feedback
1 parent 12063e5 commit fa5e841

File tree

2 files changed

+6
-4
lines changed

2 files changed

+6
-4
lines changed

addon/components/o-s-s/smart/text-area.ts

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ import { action } from '@ember/object';
22
import { isEmpty } from '@ember/utils';
33
import { tracked } from '@glimmer/tracking';
44
import { runSmartGradientAnimation } from '@upfluence/oss-components/utils/run-smart-gradient-animation';
5-
import type { OSSTextAreaArgs } from '../text-area';
5+
import type { OSSTextAreaArgs, textAreaResizeOptions } from '../text-area';
66
import OSSTextArea from '../text-area';
77

88
interface OSSSmartImmersiveInputComponentSignature extends OSSTextAreaArgs {
@@ -27,7 +27,7 @@ export default class OSSSmartTextareaComponent extends OSSTextArea<OSSSmartImmer
2727
this.element = element;
2828
}
2929

30-
get resize(): 'vertical' | 'horizontal' | 'none' {
30+
get resize(): textAreaResizeOptions | undefined {
3131
return this.args.resize ?? 'none';
3232
}
3333

addon/components/o-s-s/text-area.ts

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,11 @@ import { assert } from '@ember/debug';
22
import { action } from '@ember/object';
33
import Component from '@glimmer/component';
44

5+
export type textAreaResizeOptions = 'vertical' | 'horizontal' | 'none';
6+
57
export interface OSSTextAreaArgs {
68
rows?: number;
7-
resize?: 'vertical' | 'horizontal' | 'none';
9+
resize?: textAreaResizeOptions;
810
value?: string;
911
disabled?: boolean;
1012
errorMessage?: string;
@@ -28,7 +30,7 @@ export default class OSSTextArea<T extends OSSTextAreaArgs> extends Component<T>
2830
return this.args.rows || 2;
2931
}
3032

31-
get resize(): 'vertical' | 'horizontal' | 'none' | undefined {
33+
get resize(): textAreaResizeOptions | undefined {
3234
return this.args.resize;
3335
}
3436

0 commit comments

Comments
 (0)