Skip to content

fix(builder): settings must have a defined value #1508

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
saeta-eth wants to merge 2 commits into
base: dev
Choose a base branch
from
Open

fix(builder): settings must have a defined value #1508

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
78a14c6
fix(builder): settings must have a defined value
saeta-eth Oct 25, 2024
054beb0
Merge remote-tracking branch 'origin/dev' into fix/missing-settings
mjlescano Nov 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions packages/builder/src/definition.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,9 @@ export class ChainDefinition {
* @returns direct dependencies for the specified node
*/
computeDependencies(node: string) {
if (!_.get(this.raw, node)) {
const actionConfig = _.get(this.raw, node);

if (!actionConfig) {
const stepName = node.split('.')[0];
const possibleSteps = _.get(this.raw, stepName);

Expand All @@ -322,7 +324,13 @@ export class ChainDefinition {
`);
}

const deps = _.clone(_.get(this.raw, node)!.depends || []) as string[];
if (node.startsWith('setting') || node.startsWith('var')) {
if (_.isEmpty(actionConfig)) {
throw new Error(`invalid setting: ${node} must have a value defined`);
}
}

const deps = _.clone(actionConfig.depends || []) as string[];

const n = node.split('.')[0];

Expand All @@ -344,13 +352,13 @@ export class ChainDefinition {
possibleFields.push(baseName);
}
}
const accessComputationResults = ActionKinds[n].getInputs!(_.get(this.raw, node), possibleFields, {
const accessComputationResults = ActionKinds[n].getInputs!(actionConfig, possibleFields, {
ref: null,
currentLabel: node,
});

// Only throw this error if the user hasn't explicitly defined dependencies
if (this.sensitiveDependencies && accessComputationResults.unableToCompute && !_.get(this.raw, node).depends) {
if (this.sensitiveDependencies && accessComputationResults.unableToCompute && !actionConfig.depends) {
throw new Error(
`Unable to compute dependencies for [${node}] because of advanced logic in template strings. Specify dependencies manually, like "depends = ['${_.uniq(
_.uniq(accessComputationResults.accesses).map((a) => `${this.dependencyFor.get(a)}`)
Expand Down
Loading