From 85a753b4385932852133558e000d3453cc66298d Mon Sep 17 00:00:00 2001 From: Gray Zhang Date: Wed, 24 Sep 2025 23:40:33 +0800 Subject: [PATCH 1/3] =?UTF-8?q?feat:=20=E5=B0=86TestFlight=E5=8F=91?= =?UTF-8?q?=E5=B8=83=E6=B8=A0=E9=81=93=E4=BB=8E=E5=86=85=E6=B5=8B=E6=9B=B4?= =?UTF-8?q?=E6=96=B0=E4=B8=BA=E5=85=AC=E6=B5=8B?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - 更新 Fastfile 配置以支持公测 - 添加 "Public Beta" 测试组 - 增加更详细的 beta_app_review_info 配置 - 添加中文描述和说明 - 确保 distribute_external 设置为 true - 更新 GitHub Actions workflow 描述 - 明确标注为 Public Beta 发布 - 添加外部测试者邮件通知说明 - 配置改进 - 添加 beta_app_description - 添加 demo_account_required: false - 更新联系电话格式 现在版本发布将自动提交到 TestFlight 公测，外部测试者将收到邮件通知。 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- .github/workflows/release.yml | 14 ++++++++------ fastlane/Fastfile | 35 +++++++++++++++++++++++++---------- 2 files changed, 33 insertions(+), 16 deletions(-) diff --git a/.github/workflows/release.yml b/.github/workflows/release.yml index 3cff6a8..9a9769e 100644 --- a/.github/workflows/release.yml +++ b/.github/workflows/release.yml @@ -84,7 +84,7 @@ jobs: echo "✅ Successfully created tag: $TAG_NAME" build-and-release: - name: Build and Release to TestFlight + name: Build and Release to TestFlight (Public Beta) needs: version-check if: needs.version-check.outputs.should_release == 'true' runs-on: macos-latest @@ -290,7 +290,7 @@ jobs: export LC_ALL=en_US.UTF-8 export LANG=en_US.UTF-8 - # Run the beta lane (includes waiting for processing and distribution) + # Run the beta lane (includes waiting for processing and public beta distribution) fastlane beta - name: Create GitHub Release @@ -302,8 +302,9 @@ jobs: ## 🚀 Version ${{ needs.version-check.outputs.version }} Build: ${{ needs.version-check.outputs.build }} - ### TestFlight - This version has been automatically submitted to TestFlight for beta testing. + ### TestFlight Public Beta + This version has been automatically submitted to TestFlight for public beta testing. + External testers will receive email notifications when the build is available. ### What's New - See [commit history](https://github.com/${{ github.repository }}/commits/${{ needs.version-check.outputs.new_tag }}) for changes @@ -316,6 +317,7 @@ jobs: - name: Post release notification if: success() run: | - echo "✅ Successfully released version ${{ needs.version-check.outputs.version }} to TestFlight!" + echo "✅ Successfully released version ${{ needs.version-check.outputs.version }} to TestFlight Public Beta!" echo "🏷️ Tag: ${{ needs.version-check.outputs.new_tag }}" - echo "🔢 Build: ${{ needs.version-check.outputs.build }}" \ No newline at end of file + echo "🔢 Build: ${{ needs.version-check.outputs.build }}" + echo "📧 External testers will be notified via email" \ No newline at end of file diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 3c14425..b3926ca 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -78,20 +78,23 @@ platform :ios do api_key: api_key, app_identifier: "v2er.app", skip_submission: false, - distribute_external: true, - groups: ["External"], # Default external tester group - notify_external_testers: true, + distribute_external: true, # 发布到外部测试者（公测） + groups: ["Public Beta", "External Testers", "Beta Testers"], # 公测群组 + notify_external_testers: true, # 发送邮件通知 uses_non_exempt_encryption: false, - submit_beta_review: true, + submit_beta_review: true, # 自动提交Beta审核 wait_for_uploaded_build: true, + beta_app_description: "V2er 是一个优雅的 V2EX 第三方客户端", + beta_app_feedback_email: "support@v2er.app", + demo_account_required: false, beta_app_review_info: { contact_email: "support@v2er.app", contact_first_name: "V2er", contact_last_name: "Support", - contact_phone: "+1234567890", + contact_phone: "+86 1234567890", demo_account_name: "", demo_account_password: "", - notes: "This is a V2EX forum client app. No special account needed for testing." + notes: "这是一个 V2EX 论坛的第三方客户端应用，测试不需要特殊账号。" } ) @@ -160,13 +163,25 @@ platform :ios do skip_waiting_for_build_processing: false, # Wait for processing before distribution wait_processing_interval: 30, # Check every 30 seconds wait_processing_timeout_duration: 900, # Wait up to 15 minutes for processing - distribute_external: true, # Distribute to external testers + distribute_external: true, # 发布到外部测试者（公测） distribute_only: false, # Upload and distribute in one action - groups: ["External Testers", "Beta Testers"], # Try common group names + groups: ["Public Beta", "External Testers", "Beta Testers"], # 公测群组 changelog: "Bug fixes and improvements", - notify_external_testers: true, # Send email notifications + notify_external_testers: true, # 发送邮件通知给外部测试者 uses_non_exempt_encryption: false, # Required for automatic distribution - submit_beta_review: true # Automatically submit for beta review if needed + submit_beta_review: true, # 自动提交Beta审核 + beta_app_description: "V2er 是一个优雅的 V2EX 第三方客户端", + beta_app_feedback_email: "support@v2er.app", + demo_account_required: false, # 不需要演示账号 + beta_app_review_info: { + contact_email: "support@v2er.app", + contact_first_name: "V2er", + contact_last_name: "Support", + contact_phone: "+86 1234567890", + demo_account_name: "", + demo_account_password: "", + notes: "这是一个 V2EX 论坛的第三方客户端应用，测试不需要特殊账号。" + } ) # Notify success From 2bddb2b31451980b5b36ae97dc1475969c9f5dc6 Mon Sep 17 00:00:00 2001 From: Gray Zhang Date: Wed, 24 Sep 2025 23:45:26 +0800 Subject: [PATCH 2/3] fix: change Chinese comments to English in Fastfile MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Updated all Chinese comments to English - Fixed beta app description to English - Fixed notes in beta_app_review_info to English - Maintains consistency with English codebase 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- CLAUDE.md | 3 ++- fastlane/Fastfile | 26 +++++++++++++------------- 2 files changed, 15 insertions(+), 14 deletions(-) diff --git a/CLAUDE.md b/CLAUDE.md index f5ee02f..24cef8b 100644 --- a/CLAUDE.md +++ b/CLAUDE.md @@ -105,4 +105,5 @@ Currently contains only boilerplate test setup. - Supported architectures: armv7, arm64 - Orientation: Portrait only on iPhone, all orientations on iPad - UI Style: Light mode enforced -- Website submodule: Located at `website/` (separate repository) \ No newline at end of file +- Website submodule: Located at `website/` (separate repository) +- create PR should always use english \ No newline at end of file diff --git a/fastlane/Fastfile b/fastlane/Fastfile index b3926ca..3354bd4 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -78,13 +78,13 @@ platform :ios do api_key: api_key, app_identifier: "v2er.app", skip_submission: false, - distribute_external: true, # 发布到外部测试者（公测） - groups: ["Public Beta", "External Testers", "Beta Testers"], # 公测群组 - notify_external_testers: true, # 发送邮件通知 + distribute_external: true, # Distribute to external testers (public beta) + groups: ["Public Beta", "External Testers", "Beta Testers"], # Public beta groups + notify_external_testers: true, # Send email notifications uses_non_exempt_encryption: false, - submit_beta_review: true, # 自动提交Beta审核 + submit_beta_review: true, # Automatically submit for Beta review wait_for_uploaded_build: true, - beta_app_description: "V2er 是一个优雅的 V2EX 第三方客户端", + beta_app_description: "V2er is an elegant third-party client for V2EX forum", beta_app_feedback_email: "support@v2er.app", demo_account_required: false, beta_app_review_info: { @@ -94,7 +94,7 @@ platform :ios do contact_phone: "+86 1234567890", demo_account_name: "", demo_account_password: "", - notes: "这是一个 V2EX 论坛的第三方客户端应用，测试不需要特殊账号。" + notes: "This is a third-party client app for V2EX forum. No special account needed for testing." } ) @@ -163,16 +163,16 @@ platform :ios do skip_waiting_for_build_processing: false, # Wait for processing before distribution wait_processing_interval: 30, # Check every 30 seconds wait_processing_timeout_duration: 900, # Wait up to 15 minutes for processing - distribute_external: true, # 发布到外部测试者（公测） + distribute_external: true, # Distribute to external testers (public beta) distribute_only: false, # Upload and distribute in one action - groups: ["Public Beta", "External Testers", "Beta Testers"], # 公测群组 + groups: ["Public Beta", "External Testers", "Beta Testers"], # Public beta groups changelog: "Bug fixes and improvements", - notify_external_testers: true, # 发送邮件通知给外部测试者 + notify_external_testers: true, # Send email notifications to external testers uses_non_exempt_encryption: false, # Required for automatic distribution - submit_beta_review: true, # 自动提交Beta审核 - beta_app_description: "V2er 是一个优雅的 V2EX 第三方客户端", + submit_beta_review: true, # Automatically submit for Beta review + beta_app_description: "V2er is an elegant third-party client for V2EX forum", beta_app_feedback_email: "support@v2er.app", - demo_account_required: false, # 不需要演示账号 + demo_account_required: false, # No demo account required beta_app_review_info: { contact_email: "support@v2er.app", contact_first_name: "V2er", @@ -180,7 +180,7 @@ platform :ios do contact_phone: "+86 1234567890", demo_account_name: "", demo_account_password: "", - notes: "这是一个 V2EX 论坛的第三方客户端应用，测试不需要特殊账号。" + notes: "This is a third-party client app for V2EX forum. No special account needed for testing." } ) From ec7d88d06c83982c4918dc546e7356e1d79fbec7 Mon Sep 17 00:00:00 2001 From: Gray Zhang Date: Wed, 24 Sep 2025 23:53:05 +0800 Subject: [PATCH 3/3] fix: address PR review feedback MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Removed empty demo_account_name and demo_account_password fields (optional) - Updated placeholder phone number to a more realistic format - Kept English descriptions and notes for Apple reviewers Addresses review comments from PR #44 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude --- fastlane/Fastfile | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/fastlane/Fastfile b/fastlane/Fastfile index 3354bd4..a00fe14 100644 --- a/fastlane/Fastfile +++ b/fastlane/Fastfile @@ -91,9 +91,7 @@ platform :ios do contact_email: "support@v2er.app", contact_first_name: "V2er", contact_last_name: "Support", - contact_phone: "+86 1234567890", - demo_account_name: "", - demo_account_password: "", + contact_phone: "+86 13800138000", notes: "This is a third-party client app for V2EX forum. No special account needed for testing." } ) @@ -177,9 +175,7 @@ platform :ios do contact_email: "support@v2er.app", contact_first_name: "V2er", contact_last_name: "Support", - contact_phone: "+86 1234567890", - demo_account_name: "", - demo_account_password: "", + contact_phone: "+86 13800138000", notes: "This is a third-party client app for V2EX forum. No special account needed for testing." } )