Skip to content

CacheManifestLinker should use version numbers for cached resources #413

@vaadin-bot

Description

@vaadin-bot

Originally by jarno.rantala


Since Vaadin 7.4.0 [https://vaadin.com/download/release/7.4/7.4.0/release-notes.html] the bootstrap javascript and themes are loaded with the version number:

<script type="text/javascript" src="./VAADIN/vaadinBootstrap.js?v=7.6.0.beta1"></script>

Anyway, the current manifest file does not have a parameter. That would mean that the required resource is not cached at all so it always tries to fetch it from the server.

Current manifest:

CACHE MANIFEST
# Build timeMon Nov 30 10:03:10 EET 2015

CACHE:
../../../VAADIN/themes/base/fonts/fontawesome-webfont.woff
../../../VAADIN/themes/touchkit/styles.css
../../../VAADIN/vaadinBootstrap.js
...

There should be version numbers added to make the required resources cached

CACHE MANIFEST
# Build timeMon Nov 30 10:03:10 EET 2015

CACHE:
../../../VAADIN/themes/base/fonts/fontawesome-webfont.woff
../../../VAADIN/themes/touchkit/styles.css?v=7.6.0.beta1
../../../VAADIN/vaadinBootstrap.js?v=7.6.0.beta1
...

Imported from https://dev.vaadin.com/ issue #19321

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions