re-add encoding warning (#54)

Author: tanner0101

Sources/PostgresNIO/Connection/PostgresClient+Query.swift

@@ -65,16 +65,16 @@ private final class PostgresParameterizedQuery: PostgresRequest {
         case .parseComplete:
             return []
         case .parameterDescription:
-//            let params = try PostgresMessage.ParameterDescription(message: message)
-//            if params.dataTypes.count != binds.count {
-//                self.logger!.warning("Expected parameters count (\(params.dataTypes.count)) does not equal binds count (\(binds.count))")
-//            } else {
-//                for (i, item) in zip(params.dataTypes, binds).enumerated() {
-//                    if item.0 != item.1.type {
-//                        self.logger!.warning("bind $\(i + 1) type (\(item.1.type)) does not match expected parameter type (\(item.0))")
-//                    }
-//                }
-//            }
+            let params = try PostgresMessage.ParameterDescription(message: message)
+            if params.dataTypes.count != self.binds.count {
+                self.logger!.warning("Expected parameters count (\(params.dataTypes.count)) does not equal binds count (\(binds.count))")
+            } else {
+                for (i, item) in zip(params.dataTypes, self.binds).enumerated() {
+                    if item.0 != item.1.type {
+                        self.logger!.warning("bind $\(i + 1) type (\(item.1.type)) does not match expected parameter type (\(item.0))")
+                    }
+                }
+            }
             return []
         case .commandComplete:
             return []

Tests/PostgresNIOTests/NIOPostgresTests.swift

@@ -556,6 +556,23 @@ final class NIOPostgresTests: XCTestCase {
         XCTAssertEqual(rows[0].column("languages")?.array(of: String.self), ["en"])
         XCTAssertEqual(rows[0].column("currencies")?.array(of: String.self), ["USD", "DKK"])
     }
+
+    func testBindDate() throws {
+        // https://github.com/vapor/postgres-nio/issues/53
+        let date =  Date(timeIntervalSince1970: 1571425782)
+        let query = """
+        SELECT $1::json as "date"
+        """
+        let conn = try PostgresConnection.test(on: eventLoop).wait()
+        defer { try! conn.close().wait() }
+        do {
+            _ = try conn.query(query, [.init(date: date)]).wait()
+            XCTFail("should have failed")
+        } catch PostgresError.server(let error) {
+            XCTAssertEqual(error.fields[.routine], "report_invalid_encoding")
+        }
+
+    }
 
     // MARK: Performance
 

Tests/PostgresNIOTests/XCTestManifests.swift

@@ -7,6 +7,7 @@ extension NIOPostgresTests {
     // to regenerate.
     static let __allTests__NIOPostgresTests = [
         ("testAverageLengthNumeric", testAverageLengthNumeric),
+        ("testBindDate", testBindDate),
         ("testBindInteger", testBindInteger),
         ("testBoolSerialize", testBoolSerialize),
         ("testBytesSerialize", testBytesSerialize),