Fix some clippy lints #1400
Draft
Fix some clippy lints #1400
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During testing I encountered a few panics, because `12 -` was wrapping around. I think `saturating_sub` is the correct behavoir here
For now, VCD (the default) and FST are supported. I did this, because fst supports nicer things, e.g. struct and enum support in the wavedump. More formats can be added later easily with this approach
warning: the `Err`-variant returned from this function is very large
--> crates/analyzer/src/symbol_table.rs:1277:58
|
1277 | pub fn resolve<T: Into<SymbolPathNamespace>>(path: T) -> Result<ResolveResult, ResolveError> {
| ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ the `Err`-variant is at least 736 bytes
|
= help: try reducing the size of `symbol_table::ResolveError`, for example by boxing large elements or replacing it with `Box<symbol_table::ResolveError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
By introducing a box, we now went down from 736 to 24 bytes!
warning: the `Err`-variant returned from this function is very large
--> crates/analyzer/src/type_dag.rs:225:56
|
47 | Cyclic(Symbol, Symbol),
| ---------------------- the largest variant contains at least 1440 bytes
...
225 | pub fn insert_node(symbol_id: SymbolId, name: &str) -> Result<u32, DagError> {
| ^^^^^^^^^^^^^^^^^^^^^
|
= help: try reducing the size of `type_dag::DagError`, for example by boxing large elements or replacing it with `Box<type_dag::DagError>`
= help: for further information visit https://rust-lang.github.io/rust-clippy/master/index.html#result_large_err
Same here, but twice the amount (since `DagError` contains 2 symbols)
CodSpeed Performance ReportMerging #1400 will not alter performanceComparing Summary
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to fix some more clippy lints.
For one, I try to get the low haning fruits.
I started this PR, because I want to see, if the performance improves. It should :)