Migrates remaining tests to github runners

Signed-off-by: Mohamed L. Karaoui <moharaka@gmail.com>

Author: moharaka

.github/workflows/cri_tests.yml

@@ -16,7 +16,7 @@ jobs:
     env:
       GITHUB_RUN_ID: ${{ github.run_id }}
       GITHUB_VHIVE_ARGS: "-dbg"
-    runs-on: ${{ fromJSON(format('["self-hosted", "{0}-cri"]', inputs.sandbox)) }}
+    runs-on: ubuntu-24.04
 
     steps:
       - name: Host Info
@@ -51,7 +51,7 @@ jobs:
 
       - name: Run sandbox specific tests
         if: ${{ inputs.sandbox == 'firecracker' }}
-        run: source /etc/profile && go clean -testcache && go test ./cri/${{ inputs.sandbox }} -v -race -cover
+        run: source /etc/profile && go clean -testcache && sudo go test ./cri/${{ inputs.sandbox }} -v -race -cover
 
       - name: Archive log artifacts
         if: ${{ always() }}

.github/workflows/unit_tests.yml

@@ -69,7 +69,7 @@ jobs:
   
   profile-unit-test:
     name: "Unit test: profile unit test"
-    runs-on: [self-hosted, profile]
+    runs-on: ubuntu-24.04
     strategy:
       fail-fast: false
       matrix:

configs/knative_workloads/gvisor/helloworld.yaml

@@ -6,12 +6,12 @@ spec:
   template:
     spec:
       containers:
-        - image: ghcr.io/ease-lab/helloworld:var_workload
+        - image: ghcr.io/ease-lab/helloworld@sha256:12dc6715ed1a8306f246ceaf7742c09e38a52a79d17421e4a50d7e0e09fdbc25
           ports:
             - name: h2c # For GRPC support
               containerPort: 50051
           env:
             - name: GUEST_PORT # Port on which the firecracker-containerd container is accepting requests
               value: "50051"
             - name: GUEST_IMAGE # Container image to use for firecracker-containerd container
-              value: "ghcr.io/ease-lab/helloworld:var_workload"
+              value: "ghcr.io/ease-lab/helloworld@sha256:12dc6715ed1a8306f246ceaf7742c09e38a52a79d17421e4a50d7e0e09fdbc25"

scripts/github_runner/setup_cri_test_env.sh

@@ -35,16 +35,33 @@ fi
 SANDBOX=$1
 VHIVE_ROOT="$(git rev-parse --show-toplevel)"
 
+echo "=== Setting-Up node ==="
+# Set up the node with proper firecracker-containerd installation
+$VHIVE_ROOT/scripts/setup_tool -vhive-repo-dir $VHIVE_ROOT setup_node $SANDBOX
+
+echo "=== Setting-Up onenode-vhive ==="
 $VHIVE_ROOT/scripts/setup_tool -vhive-repo-dir $VHIVE_ROOT start_onenode_vhive_cluster $SANDBOX
 # $VHIVE_ROOT/scripts/cloudlab/start_onenode_vhive_cluster.sh "$SANDBOX"
 sleep 30s
 
+echo "=== Setting-Up zipkin ==="
 # KUBECONFIG=/etc/kubernetes/admin.conf sudo $VHIVE_ROOT/scripts/setup_zipkin.sh
-$VHIVE_ROOT/scripts/setup_tool -vhive-repo-dir $VHIVE_ROOT setup_zipkin
+#$VHIVE_ROOT/scripts/setup_tool -vhive-repo-dir $VHIVE_ROOT setup_zipkin
 
 # FIXME (gh-709)
 #source etc/profile && go run $VHIVE_ROOT/examples/registry/populate_registry.go -imageFile $VHIVE_ROOT/examples/registry/images.txt
 
+echo "=== Kubernetes Status ==="
+sudo KUBECONFIG=/etc/kubernetes/admin.conf kubectl get nodes -o wide
+sudo KUBECONFIG=/etc/kubernetes/admin.conf kubectl get pods --all-namespaces
+echo "=== Knative Components ==="
+sudo KUBECONFIG=/etc/kubernetes/admin.conf kubectl get pods -n knative-serving
+sudo KUBECONFIG=/etc/kubernetes/admin.conf kubectl get ksvc --all-namespaces
+
+
+echo "=== Activator Status ===" && sudo KUBECONFIG=/etc/kubernetes/admin.conf kubectl describe pod -n knative-serving -l app=activator
+echo "=== Activator Logs ===" && sudo KUBECONFIG=/etc/kubernetes/admin.conf kubectl logs -n knative-serving -l app=activator
+
 sudo KUBECONFIG=/etc/kubernetes/admin.conf kn service apply helloworld -f $VHIVE_ROOT/configs/knative_workloads/$SANDBOX/helloworld.yaml
 sudo KUBECONFIG=/etc/kubernetes/admin.conf kn service apply helloworldserial -f $VHIVE_ROOT/configs/knative_workloads/$SANDBOX/helloworldSerial.yaml
 sudo KUBECONFIG=/etc/kubernetes/admin.conf kn service apply pyaes -f $VHIVE_ROOT/configs/knative_workloads/$SANDBOX/pyaes.yaml

scripts/setup_firecracker_containerd.sh

@@ -61,3 +61,7 @@ if [ 64 -eq ${#CONTAINERID} ]; then
 fi
 
 sudo cp $CONFIGS/firecracker-runtime.json /etc/containerd/
+
+# Create directory and symlink for CRI socket
+sudo mkdir -p /etc/vhive-cri
+sudo ln -sf /run/firecracker-containerd/containerd.sock /etc/vhive-cri/vhive-cri.sock

snapshotting/manager.go

@@ -41,15 +41,19 @@ type SnapshotManager struct {
 }
 
 // Snapshot identified by VM id
-
 func NewSnapshotManager(baseFolder string) *SnapshotManager {
 	manager := new(SnapshotManager)
 	manager.snapshots = make(map[string]*Snapshot)
 	manager.baseFolder = baseFolder
 
-	// Clean & init basefolder
-	_ = os.RemoveAll(manager.baseFolder)
-	_ = os.MkdirAll(manager.baseFolder, os.ModePerm)
+	if err := os.RemoveAll(manager.baseFolder); err != nil {
+		log.Printf("Failed to clean base folder: %v", err)
+		return nil
+	}
+	if err := os.MkdirAll(manager.baseFolder, 0755); err != nil {
+		log.Printf("Failed to create base folder: %v", err)
+		return nil
+	}
 
 	return manager
 }