[BugFix] Fix deepseek v3.2 mtp bug. #3900
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This PR addresses a bug in the deepseek v3.2 mtp implementation by incorporating the DeepseekV32IndexerCache class and adjusting the logic for identifying attention layers in the draft model. The changes ensure that the indexer layers are correctly excluded from the draft attention layers, preventing potential errors during speculative decoding.
Signed-off-by: whx-sjtu <2952154980@qq.com>
wangxiyuan
approved these changes
Oct 31, 2025
wangxiyuan
approved these changes
Nov 4, 2025
Pz1116
pushed a commit
to Pz1116/vllm-ascend
that referenced
this pull request
Nov 5, 2025
### What this PR does / why we need it? This PR fixes deepseek v3.2 mtp bug. ### Does this PR introduce _any_ user-facing change? None ### How was this patch tested? All existed ci tests should pass. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b --------- Signed-off-by: whx-sjtu <2952154980@qq.com> Signed-off-by: Pz1116 <zpbzpb123123@gmail.com>
luolun
pushed a commit
to luolun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
### What this PR does / why we need it? This PR fixes deepseek v3.2 mtp bug. ### Does this PR introduce _any_ user-facing change? None ### How was this patch tested? All existed ci tests should pass. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b --------- Signed-off-by: whx-sjtu <2952154980@qq.com> Signed-off-by: luolun <luolun1995@cmbchina.com>
hwhaokun
pushed a commit
to hwhaokun/vllm-ascend
that referenced
this pull request
Nov 19, 2025
### What this PR does / why we need it? This PR fixes deepseek v3.2 mtp bug. ### Does this PR introduce _any_ user-facing change? None ### How was this patch tested? All existed ci tests should pass. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b --------- Signed-off-by: whx-sjtu <2952154980@qq.com> Signed-off-by: hwhaokun <haokun0405@163.com>
NSDie
pushed a commit
to NSDie/vllm-ascend
that referenced
this pull request
Nov 24, 2025
### What this PR does / why we need it? This PR fixes deepseek v3.2 mtp bug. ### Does this PR introduce _any_ user-facing change? None ### How was this patch tested? All existed ci tests should pass. - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b --------- Signed-off-by: whx-sjtu <2952154980@qq.com> Signed-off-by: nsdie <yeyifan@huawei.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it?
This PR fixes deepseek v3.2 mtp bug.
Does this PR introduce any user-facing change?
None
How was this patch tested?
All existed ci tests should pass.