-
Notifications
You must be signed in to change notification settings - Fork 622
[Feature][Build] Upgrade the minimum version to 3.10 #3926
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
👋 Hi! Thank you for contributing to the vLLM Ascend project. The following points will speed up your PR merge:
If CI fails, you can run linting and testing checks locally according Contributing and Testing. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request correctly updates the minimum required Python version to 3.10, removing support for Python 3.9. The changes across the README files and setup configuration are mostly consistent. I have added one suggestion to setup.py to also include an upper version limit for Python, which will prevent users from installing the package on unsupported versions and improve dependency resolution.
Thanks! Ready now. |
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Signed-off-by: gcanlin <canlinguosdu@gmail.com>
|
@wangxiyuan Could this PR be merged forcibly? It only changes some docs. |
### What this PR does / why we need it? Closes vllm-project#3728, vllm-project#3657. The main branch is now aligned with the vllm `releases/v0.11.1` branch, which no longer supports `Python 3.9`. Check it [here](https://github.com/vllm-project/vllm/blob/releases/v0.11.1/pyproject.toml). ### Does this PR introduce _any_ user-facing change? The newest version of vllm-ascend don't support Python 3.9. ### How was this patch tested? - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: gcanlin <canlinguosdu@gmail.com> Signed-off-by: luolun <luolun1995@cmbchina.com>
### What this PR does / why we need it? Closes vllm-project#3728, vllm-project#3657. The main branch is now aligned with the vllm `releases/v0.11.1` branch, which no longer supports `Python 3.9`. Check it [here](https://github.com/vllm-project/vllm/blob/releases/v0.11.1/pyproject.toml). ### Does this PR introduce _any_ user-facing change? The newest version of vllm-ascend don't support Python 3.9. ### How was this patch tested? - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: gcanlin <canlinguosdu@gmail.com> Signed-off-by: hwhaokun <haokun0405@163.com>
### What this PR does / why we need it? Closes vllm-project#3728, vllm-project#3657. The main branch is now aligned with the vllm `releases/v0.11.1` branch, which no longer supports `Python 3.9`. Check it [here](https://github.com/vllm-project/vllm/blob/releases/v0.11.1/pyproject.toml). ### Does this PR introduce _any_ user-facing change? The newest version of vllm-ascend don't support Python 3.9. ### How was this patch tested? - vLLM version: v0.11.0 - vLLM main: vllm-project/vllm@83f478b Signed-off-by: gcanlin <canlinguosdu@gmail.com> Signed-off-by: nsdie <yeyifan@huawei.com>
What this PR does / why we need it?
Closes #3728, #3657.
The main branch is now aligned with the vllm
releases/v0.11.1branch, which no longer supportsPython 3.9. Check it here.Does this PR introduce any user-facing change?
The newest version of vllm-ascend don't support Python 3.9.
How was this patch tested?