🐛 [Bug][Account] The "account set password" not working correctly.

[gajet5]

🐛 Bug report

https://youtu.be/6WjPPUvd9Uc

Expected behavior

The password is changed correctly.

Steps to reproduce

1. Run server
2. go to consol
3. set for some account password "account set password SOME_ACC pass1 pass2"
4. Profit

Version & Environment

Client Version: 1.12.1.5875

Commit Hash:

OS Client: Windows
OS Server: Ubuntu 24.04

Crashlog

• None

[gajet5]

Additional information. This only works for older accounts.
https://youtu.be/ICM9MJOqUdM

[gajet5]

The problem is with the email. It is used when generating the hash, but not at the moment of login. Therefore, we get a strange situation.

I commented out this part, after which the console command worked fine. And I was able to log in to my account.

bool AccountMgr::GetName(uint32 accountId, std::string &name)
{
    /*{
        std::shared_lock<std::shared_timed_mutex> guard(m_accountPersistentDataMutex);
        auto itr = m_accountPersistentData.find(accountId);
        if (itr != m_accountPersistentData.end() && !itr->second.m_email.empty())
        {
            name = itr->second.m_email;
            return true;
        }
    }*/

    std::unique_ptr<QueryResult> result = LoginDatabase.PQuery("SELECT `username` FROM `account` WHERE `id` = '%u'", accountId);
    if (result)
    {
        name = (*result)[0].GetCppString();
        if (normalizeString(name))
            return true;
    }

    return false;
}