Skip to content

[NPT-806] Fix issue with parents map in node parser #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kacpersaw wants to merge 1 commit into
base: main
Choose a base branch
from
Open

[NPT-806] Fix issue with parents map in node parser #114

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 14 additions & 4 deletions compiler/pkg/parser/node_parser.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,13 +120,21 @@ func ParseDSLNodes(startPath string, baseGroupName string, packages Packages,
for _, child := range node.SingleChildren {
// if rootNode is a child then remove it from the slice
if child.CrdName == rootNode {
rootNodes = append(rootNodes[:i], rootNodes[i+1:]...)
if i+1 >= len(rootNodes) {
rootNodes = rootNodes[:i]
} else {
rootNodes = append(rootNodes[:i], rootNodes[i+1:]...)
}
}
}
for _, child := range node.MultipleChildren {
// if rootNode is a named child then remove it from the slice
if child.CrdName == rootNode {
rootNodes = append(rootNodes[:i], rootNodes[i+1:]...)
if i+1 >= len(rootNodes) {
rootNodes = rootNodes[:i]
} else {
rootNodes = append(rootNodes[:i], rootNodes[i+1:]...)
}
}
}
}
Expand Down Expand Up @@ -249,8 +257,10 @@ func processNode(node *Node, nodes map[string]Node, baseGroupName string) {
if !ok {
log.Fatalf("Internal compiler failure: couldn't find node for key %v", key)
}
n.Parents = node.Parents
n.Parents = append(n.Parents, node.CrdName)
p := make([]string, len(node.Parents))
copy(p, node.Parents)

n.Parents = append(p, node.CrdName)
processNode(&n, nodes, baseGroupName)

if isNamed {
Expand Down