Skip to content

[Phase 3] Remove Redundant Editor Implementations After LSP Migration #37

@vogella

Description

@vogella

Description

After LSP features are fully implemented and tested, remove the redundant direct editor implementations that have been replaced by LSP equivalents.

Scope

Files to Remove (once LSP equivalents are verified)

From com.vogella.ide.editor.asciidoc:

  • AsciidocContentAssistProcessor.java - replaced by LSP completion
  • IncludeHyperlinkDetector.java - replaced by LSP document links
  • ImageHyperlinkDetector.java - replaced by LSP document links
  • LinkHyperlinkDetector.java - replaced by LSP document links
  • ResourceHyperlink.java - replaced by LSP navigation
  • ImageHover.java - replaced by LSP hover

Extension Point Registrations to Remove

From com.vogella.ide.editor.asciidoc/plugin.xml:

  • org.eclipse.ui.genericeditor.contentAssistProcessors registration
  • org.eclipse.ui.workbench.texteditor.hyperlinkDetectors registrations (3x)
  • org.eclipse.ui.genericeditor.hoverProviders registration

Files/Features to KEEP

  • TextMate grammar (syntaxes/asciidoc.json)
  • Language configuration (language-configurations/asciidoc.json)
  • Compare/merge viewer (AsciidocMergeViewer.java, etc.)
  • Content type definitions
  • Editor icon

Test Migration Strategy

Before removal:

  1. Create feature flag or preference to toggle between editor/LSP implementations
  2. Run all existing tests against LSP implementation
  3. Verify feature parity with original implementation
  4. Get user feedback on LSP version

Testing After Removal

  • All editor features still work via LSP
  • No regression in functionality
  • Performance is acceptable or better
  • Update existing tests to work with LSP
  • Clean build with no warnings

Dependencies

All Phase 1 issues must be completed and verified:

Priority: Low (do last)

Estimated Effort: 1-2 days

Metadata

Metadata

Assignees

No one assigned

    Labels

    enhancementNew feature or request

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions