-
Notifications
You must be signed in to change notification settings - Fork 4
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Description
After LSP features are fully implemented and tested, remove the redundant direct editor implementations that have been replaced by LSP equivalents.
Scope
Files to Remove (once LSP equivalents are verified)
From com.vogella.ide.editor.asciidoc:
AsciidocContentAssistProcessor.java- replaced by LSP completionIncludeHyperlinkDetector.java- replaced by LSP document linksImageHyperlinkDetector.java- replaced by LSP document linksLinkHyperlinkDetector.java- replaced by LSP document linksResourceHyperlink.java- replaced by LSP navigationImageHover.java- replaced by LSP hover
Extension Point Registrations to Remove
From com.vogella.ide.editor.asciidoc/plugin.xml:
org.eclipse.ui.genericeditor.contentAssistProcessorsregistrationorg.eclipse.ui.workbench.texteditor.hyperlinkDetectorsregistrations (3x)org.eclipse.ui.genericeditor.hoverProvidersregistration
Files/Features to KEEP
- TextMate grammar (
syntaxes/asciidoc.json) - Language configuration (
language-configurations/asciidoc.json) - Compare/merge viewer (
AsciidocMergeViewer.java, etc.) - Content type definitions
- Editor icon
Test Migration Strategy
Before removal:
- Create feature flag or preference to toggle between editor/LSP implementations
- Run all existing tests against LSP implementation
- Verify feature parity with original implementation
- Get user feedback on LSP version
Testing After Removal
- All editor features still work via LSP
- No regression in functionality
- Performance is acceptable or better
- Update existing tests to work with LSP
- Clean build with no warnings
Dependencies
All Phase 1 issues must be completed and verified:
- [Phase 1] Connect LSP Server to .adoc Content Type #27, [Phase 1] Implement File-System-Aware Completion in LSP #28, [Phase 1] Migrate Hyperlink Detectors to LSP Document Links #29, [Phase 1] Migrate Image Hover to LSP Hover Provider #30, [Phase 1] Implement Proper AsciiDoc Document Symbols #31, [Phase 1] Enhance LSP Diagnostics with Broken Reference Detection #32
Priority: Low (do last)
Estimated Effort: 1-2 days
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request