This repository was archived by the owner on Jan 26, 2024. It is now read-only.
Fixed Remove outline of input search bar #687 #689
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
priyal-hotwax seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account. You have signed the CLA already but the status is still pending? Let us recheck it. |
Author
|
|
dt2patel
suggested changes
Dec 10, 2021
Collaborator
dt2patel
left a comment
dt2patel
left a comment
There was a problem hiding this comment.
Please take a look at my comment. Mostly looks good though.
dt2patel
suggested changes
Oct 3, 2022
| } | ||
| } | ||
| .sf-input input, .sf-search-bar__input { |
Collaborator
There was a problem hiding this comment.
move styling to search bar component.
https://github.com/vuestorefront/vsf-capybara/blob/develop/components/organisms/o-search.vue
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related Issues
Closes #687
Short Description and Why It's Useful
Screenshots of Visual Changes before/after (If There Are Any)
IMPORTANT NOTICE - Remember to update
CHANGELOG.mdwith description of your changeContribution and Currently Important Rules Acceptance