Merge pull request #2534 from DivanteLtd/hotfix/v1.8.3

Hotfix/v1.8.3

Author: patzick

CHANGELOG.md

@@ -4,6 +4,52 @@ All notable changes to this project will be documented in this file.
 The format is based on [Keep a Changelog](https://keepachangelog.com/en/1.0.0/)
 and this project adheres to [Semantic Versioning](https://semver.org/spec/v2.0.0.html).
 
+## [1.8.3] - 2019.03.03
+
+### Added
+- New reactive helper to check online state. Usage: `import { onlineHelper } from '@vue-storefront/core/helpers'` and then `onlineHelper.isOnline` - @patzick (#2510)
+- Cart count config, allows you to display the item count instead of a sum of the item quantities - @pauluse (#2483)
+- Video support in Product Gallery component. - @rain2o (#2433)
+
+### Fixed
+- Problem with placing second order (unbinding payment methods after first order) - @patzick (#2195, #2503)
+- Remaking order on user orders page - @patzick (#2480)
+- Images blinking on category page - @pkarw (#2523)
+- state.ts not bound in the module-template - @pkarw (#2496)
+- Validation in the Myprofile section for postcode field - @pkarw (#1317)
+- Non-integer qty of product added to the cart - @pkarw (#2517)
+
+### Changed / Improved
+- Fixed an issue where the correct image for a product configuration wasn't set on the product page image carousel. Also added the fix on the productcarousel in the zoom component - @DaanKouters (#2419)
+- Way of creating VS Modules was changed to use factory method instead of explict object creation. - @filrak (#2434)
+- Added clear filters button on desktop also and only show if filters are applied - @DaanKouters (#2342)
+- Improved docs at contributing.md and configuration.md (spelling etc.) - @ruthgeridema (#2421, #2422, #2423, #2425, #2426)
+- Fixed design issue of Country label on Edge 17 & Firefox - @ananth-iyer (#2390, #2399)
+- Wishlist and compare items are loaded from local cache only once, instead of every time when module component is rendered - @patzick (#2431)
+- Country field is filled by first counry from the list in cart in paymen section - @RakowskiPrzemyslaw (#2428)
+- Improved product quantity change component in product and cart - @patzick (#2398, #2437)
+- Updated to Vue 2.6.6 - @filrak (#2456)
+- Null sidebar menu data on static page fixed - @filrak (#2449, #2441)
+- Fix cannot edit previous steps in checkout - @filrak, @patzick (#2438)
+- Fixed route guard ssr problem - @vue-kacper (#2364)
+- Fix links in footer to static pages bug - @filrak (#2452)
+- Fix links at docs, Basics/Configuration file explained - @daksamit (#2490)
+- Improve images loading on category page, corrected alt view and blinking problem - @patzick (#2465)
+- Improve tsconfig for better IDE paths support - @patzick, @filrak (#2474)
+- fix breadcrumbs changing too early - @filrak, @pkarw (#2469, #2529)
+- improved product gallery load view, shows correct image on reload - @patzick (#2481, #2482, #2488, #2501)
+- Fix an issue where the index.html template within a theme is ignored - @EnthrallRecords (#2489) 
+- Added async sidebar component with async off-screen components error handling and fetch retrying after coming back online - @filrak (#2408, #2451)
+- Inconsistent filters behaviour - clear filters on page load - @patzick (#2435)
+- fix price is never below 0 and user can't add 0 or below 0 products to cart - @RakowskiPrzemyslaw (#2437)
+- Check for placing single order in case of error in any payment module - @patzick (#2409)
+- Display prices in products added in offline mode. - @patzick (#2450)
+- Updated cypress dependency for e2e tests - @lukeromanowicz (#2518)
+- Improved styles on recommendation filters, product tile and numeric input - @patzick (#2458)
+
+### Deprecated / Removed
+- `@vue-storefront/store` package deprecated - @filrak
+
 ## [1.8.2] - 2019.02.11
 - Fixed docker-compose configuration for network_mode and TS build config - @lukeromanowicz (#2415)
 
@@ -50,7 +96,7 @@ Additional migration tips are available [here](https://github.com/DivanteLtd/vue
 - Improve sortBy mobile view - @martaradziszewska (#2251)
 - Slide animations to menu, search, wishlist and minicart components - @Aekal (#2256)
 - Fixed wishlist store module to not be lazy loaded - @vue-kacper (#2249)
-- Share webpack typescript config with docker container - @lukeromanowicz (#2269)
+- Share webpack typescript config with Docker container - @lukeromanowicz (#2269)
 - After checkout create logged-in cart for logged-in users if using order Direct Backend Sync - @grimasod (#2302)
 - Output cache clearing supports versioning - @igloczek (#2333, #2359)
 - Cash on delivery + Shipping addresses fixed for virtual products - @pkarw (#2366)

CONTRIBUTING.md

@@ -9,6 +9,7 @@ Before you type an issue please read about out [release lifecycle](https://docs.
 
 # Branches
 
+You should fork the project or create a branch for new features.
 The main branches used by the core team are:
 
 - master - where we store the stable release of the app (that can be deployed to our demo instances),
@@ -19,7 +20,7 @@ Please use "develop" or "RC" for development purposes as the "master" can be mer
 
 ## Issue reporting guidelines:
 
-Always define type of issue:
+Always define the type of issue:
 * Bug report
 * Feature request
 
@@ -29,20 +30,22 @@ All requests regarding support with implementation or application setup should b
 **Tag your issues properly**. If you found a bug tag it with `bug` label. If you're requesting new feature tag it with `feature request`  label.
 
 ## Git flow
+We're introducing TypeScript to Vue Storefront core, so You can use it where it's appropriate - but please be pragmatic.
+Here are some thoughts on how to use TS features in Vue Storefront: [TypeScript Action Plan](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/TypeScript%20Action%20Plan.md).
 
 ## Pull request Checklist
 
-Here’s how to submit a pull request. <b>Pull request that dont meet this requirements will not be merged.</b>
+Here’s how to submit a pull request. <b>Pull request that don't meet these requirements will not be merged.</b>
 
 **ALWAYS** use [Pull Request template](https://github.com/DivanteLtd/vue-storefront/blob/master/PULL_REQUEST_TEMPLATE.md) it's automatically added to each PR.
-1. Fork the repository and clone it locally fro the 'develop' branch. Make sure its up to date with current `develop` branch
+1. Fork the repository and clone it locally fro the 'develop' branch. Make sure it's up to date with current `develop` branch
 2. Create a branch for your edits. Use the following branch naming conventions:
  * bugfix/task-title
  * feature/task-name
 3. Use Pull Request template and fill as much fields as possible to describe your solution.
 4. Reference any relevant issues or supporting documentation in your PR (ex. “Issue: 39. Issue title.”).
-5. If you are adding new feature provide documentation along with the PR. Also add it to [upgrade notes](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/Upgrade%20notes.md)
-6. If you are removing/renaming something or changing it's behavior also include it in [upgrade notes](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/Upgrade%20notes.md)
+5. If you are adding new feature provide documentation along with the PR. Also, add it to [upgrade notes](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/Upgrade%20notes.md)
+6. If you are removing/renaming something or changing its behavior also include it in [upgrade notes](https://github.com/DivanteLtd/vue-storefront/blob/master/doc/Upgrade%20notes.md)
 7. Test your changes! Run your changes against any existing tests and create new ones when needed. Make sure your changes don’t break the existing project. Make sure that your branch is passing Travis CI build. 
 8. If you have found a potential security vulnerability, please DO NOT report it on the public issue tracker. Instead, send it to us at contributors@vuestorefront.io. We will work with you to verify and fix it as soon as possible.
 (https://github.com/DivanteLtd/vue-storefront/blob/master/README.md#documentation--table-of-contents))

README.md

@@ -15,7 +15,7 @@ The project is in the **production ready** phase.
 
 **Important note to developers:** From 1.0RC we started using [develop](https://github.com/DivanteLtd/vue-storefront/tree/develop) branch for nightly builds (contains all new features) and [master](https://github.com/DivanteLtd/vue-storefront/tree/master) branch for stable. Please make sure you're working on right branch. Please take a look at [Contributing guidelines](https://github.com/DivanteLtd/vue-storefront/blob/master/CONTRIBUTING.md).
 
-If you're new and need some guidance feel free to reach anyone from core team on our slack:
+If you're new and need some guidance feel free to reach anyone from the core team on our slack:
 - `@Filip Rakowski` (frontend, architecture and best practices related stuff)
 - `@pkarw` (integrations and backend related stuff)
 - `@ptomczyk` (frontend related stuff)
@@ -28,7 +28,7 @@ Want to invest some time in building the future of eCommerce? we are looking for
 
 See the ideas behind Vue Storefront [here](https://www.slideshare.net/FilipRakowski/vue-storefront-basics)
 
-**Read [contribution rules](https://github.com/DivanteLtd/vue-storefront/blob/master/CONTRIBUTING.md) before making any pull request. Pull request that don't meet this requirements will not be merged**
+**Read [contribution rules](https://github.com/DivanteLtd/vue-storefront/blob/master/CONTRIBUTING.md) before making any pull request. Pull request that doesn't meet these requirements will not be merged**
 
 ## See it in action
 
@@ -74,13 +74,13 @@ If you have any questions or ideas feel free to join our slack: https://vuestore
 [Here](https://github.com/DivanteLtd/vue-storefront/milestones) you can find the accepted roadmap for current milestone and what you can expect with next release.
 
 #### Roadmap planning
-[Here](https://github.com/DivanteLtd/vue-storefront/projects/3) you can vote for feature requests and see which ones were accepted. The most upvoted ones will be added to next milestones. You can also join the slack channel `#roadmap-planning` where we discuss the next milestones.
+[Here](https://github.com/DivanteLtd/vue-storefront/projects/3) you can vote for feature requests and see which ones were accepted. The most upvoted ones will be added to the next milestones. You can also join the slack channel `#roadmap-planning` where we discuss the next milestones.
 
 The process of adding new features to the roadmap looks like this:
 1. You create an issue and label it as `feature request`.
 2. One of VS Core team verifies the feature request and if the explanation is clear, it is added to the `Roadmap` project so it's visible in the board.
 3. Now people can vote for this feature to be added into next milestone with `thumb up` emoji.
-4. Feature requests with biggest popularity will be added into next milestones.
+4. Feature requests with the biggest popularity will be added into next milestones.
 
 We are planning 1-2 milestones ahead. Our milestones are based on requirements from community, partners and production implementations.
 
@@ -171,7 +171,7 @@ Check [Vue Storefront Awesome](https://github.com/frqnck/awesome-vue-storefront)
 
 ## The business challenges
 
-Vue Storefront was created to solve a set of key business challenges from the world of shopping experience. Our goal for the application is to provide the solution with:
+Vue Storefront was created to solve a set of key business challenges from the world of the shopping experience. Our goal for the application is to provide the solution with:
 
 - The ultrafast front-end for the store - with the PWA approach we can now render the catalog of products within milliseconds;
 - The endurance for traffic overloads on the store;
@@ -193,7 +193,7 @@ Besides a big improvement for the shopping experience, we also want to create a
 
 ## The design
 
-The application is prepared to be fully customized in design through theming system.
+The application is prepared to be fully customized in design through the theming system.
 With the current version we work on raw, basic template of typical eCommerce for a fashion industry.
 In the project we used [Material Icons](https://github.com/google/material-design-icons).
 
@@ -206,7 +206,7 @@ Here you can read more about the process of [designing PWA for eCommerce](https:
 The design is available in open source in the Figma file format under the URL https://www.figma.com/file/VKyqbHFI55TKIKcQlFLiVpVF/Vue-Storefront-Open-Source.
 
 ## Other platforms
-Vue Storefront is platform agnostic which means it can be connected to virtually any CMS. Please take a look at [Pimcore bridge](https://github.com/DivanteLtd/coreshop-vsbridge) to give you an idea on how other platforms can be connected. Any support for integrating Prestashop, Shopify ... - much appreciated.
+Vue Storefront is platform agnostic which means it can be connected to virtually any CMS. Please take a look at [Pimcore bridge](https://github.com/DivanteLtd/coreshop-vsbridge) to give you an idea of how other platforms can be connected. Any support for integrating Prestashop, Shopify ... - much appreciated.
 
 ## The license
 
@@ -220,7 +220,7 @@ If you have discovered a 🐜 or have a feature suggestion, feel free to create
 
 ## Workshops
 
-If you like our project and would like to learn more on how to create Progressive Web Apps you can ask us for dedicated workshop at your office! Conducted by Vue Storefront core contributors! All the profits are used for supporting Vue Storefront development. [Learn more](https://products.divante.co/vuestorefront/)
+If you like our project and would like to learn more on how to create Progressive Web Apps you can ask us for a dedicated workshop at your office! Conducted by Vue Storefront core contributors! All the profits are used for supporting Vue Storefront development. [Learn more](https://products.divante.co/vuestorefront/)
 
 ## Support us!
 
@@ -626,7 +626,7 @@ Vue Storefront is a Community effort brought to You by our great Core Team and s
   </tbody>
 </table>
 
-Partners are encouraged to support the project by various ways - mostly by contributing the source code, marketing activities, evangelizing and of course - implementing the production projects. We do support our partners by dedicated contact channels, workshops and by sharing the leads from merchants interested in implementations.
+Partners are encouraged to support the project in various ways - mostly by contributing the source code, marketing activities, evangelizing and of course - implementing the production projects. We do support our partners by dedicated contact channels, workshops and by sharing the leads from merchants interested in implementations.
 
 If you like to become our Partner just let us know via contributors@vuestorefront.io.
 

config/default.json

@@ -235,6 +235,7 @@
       "setConfigurableProductOptions": true,
       "askBeforeRemoveProduct": true,
       "displayItemDiscounts": true,
+      "minicartCountType": "quantities",
       "create_endpoint": "http://localhost:8080/api/cart/create?token={{token}}",
       "updateitem_endpoint": "http://localhost:8080/api/cart/update?token={{token}}&cartId={{cartId}}",
       "deleteitem_endpoint": "http://localhost:8080/api/cart/delete?token={{token}}&cartId={{cartId}}",

core/app.ts

@@ -29,11 +29,11 @@ import * as corePlugins from '@vue-storefront/core/compatibility/plugins'
 
 import { once } from '@vue-storefront/core/helpers'
 import { takeOverConsole } from '@vue-storefront/core/helpers/log'
-import store from '@vue-storefront/store'
+import store from '@vue-storefront/core/store'
 
 import { enabledModules } from './modules-entry'
 
-// Will be depreciated in 1.8
+// Will be deprecated in 1.8
 import { registerExtensions } from '@vue-storefront/core/compatibility/lib/extensions'
 import { registerExtensions as extensions } from 'src/extensions'
 
@@ -65,7 +65,7 @@ const createApp  = async (ssrContext, config): Promise<{app: Vue, router: VueRou
   // sync router with vuex 'router' store
   sync(store, router)
   // TODO: Don't mutate the state directly, use mutation instead
-  store.state.version = '1.7.0'
+  store.state.version = '1.8.3'
   store.state.config = config
   store.state.__DEMO_MODE__ = (config.demomode === true) ? true : false
   if(ssrContext) Vue.prototype.$ssrRequestContext = ssrContext

core/build/dev-server.js

@@ -15,15 +15,15 @@ module.exports = function setupDevServer (app, cb) {
   let bundle
   let template
 
-  // modify client config to work with hot middleware
+  // Modify client config to work with hot middleware
   clientConfig.entry.app = ['webpack-hot-middleware/client', ...clientConfig.entry.app]
   clientConfig.output.filename = '[name].js'
   clientConfig.plugins.push(
     new webpack.HotModuleReplacementPlugin(),
     new webpack.NoEmitOnErrorsPlugin()
   )
 
-  // dev middleware
+  // Dev middleware
   const clientCompiler = webpack(clientConfig)
   const devMiddleware = require('webpack-dev-middleware')(clientCompiler, {
     publicPath: clientConfig.output.publicPath,
@@ -44,7 +44,7 @@ module.exports = function setupDevServer (app, cb) {
     }
   })
 
-  // hot middleware
+  // Hot middleware
   app.use(require('webpack-hot-middleware')(clientCompiler))
 
   // watch and update server renderer
@@ -57,7 +57,7 @@ module.exports = function setupDevServer (app, cb) {
     stats.errors.forEach(err => console.error(err))
     stats.warnings.forEach(err => console.warn(err))
 
-    // read bundle generated by vue-ssr-webpack-plugin
+    // Read bundle generated by vue-ssr-webpack-plugin
     const bundlePath = path.join(serverConfig.output.path, 'vue-ssr-bundle.json')
     bundle = JSON.parse(mfs.readFileSync(bundlePath, 'utf-8'))
     if (template) {

core/build/webpack.base.config.ts

@@ -19,7 +19,7 @@ import themeRoot from './theme-path';
 const themeResources = themeRoot + '/resource'
 const themeCSS = themeRoot + '/css'
 const themeApp = themeRoot + '/App.vue'
-const themedIndex = path.join(themeRoot, 'index.template.html')
+const themedIndex = path.join(themeRoot, '/templates/index.template.html')
 const themedIndexMinimal = path.join(themeRoot, '/templates/index.minimal.template.html')
 const themedIndexBasic = path.join(themeRoot, '/templates/index.basic.template.html')
 const themedIndexAmp = path.join(themeRoot, '/templates/index.amp.template.html')
@@ -110,7 +110,7 @@ export default {
       'theme/resource': themeResources,
 
       // Backward compatible
-      '@vue-storefront/store/lib/multistore' : path.resolve(__dirname, '../lib/multistore.ts'),
+      '@vue-storefront/core/store/lib/multistore' : path.resolve(__dirname, '../lib/multistore.ts'),
     }
   },
   module: {

core/build/webpack.prod.sw.config.ts

@@ -79,15 +79,15 @@ module.exports = merge(base, {
         urlPattern: "/dist/(.*)",
         handler: "fastest"
       },{
-        urlPattern: "/*/*", /** this is new product url format  */
+        urlPattern: "/*/*", /** this is new product URL format  */
         handler: "networkFirst"
       },
       {
-        urlPattern: "/*/*/*", /** this is new product url format  */
+        urlPattern: "/*/*/*", /** this is new product URL format  */
         handler: "networkFirst"
       },
       {
-        urlPattern: "/*", /** this is new category url format  */
+        urlPattern: "/*", /** this is new category URL format  */
         handler: "networkFirst"
       }],
       "importScripts": ['/dist/core-service-worker.js'] /* custom logic */

core/client-entry.ts

@@ -4,11 +4,11 @@ import union from 'lodash-es/union'
 
 import { createApp } from '@vue-storefront/core/app'
 import EventBus from '@vue-storefront/core/compatibility/plugins/event-bus/index'
-import rootStore from '@vue-storefront/store'
+import rootStore from '@vue-storefront/core/store'
 
 import buildTimeConfig from 'config'
 import { execute } from '@vue-storefront/core/lib/sync/task'
-import UniversalStorage from '@vue-storefront/store/lib/storage'
+import UniversalStorage from '@vue-storefront/core/store/lib/storage'
 import i18n from '@vue-storefront/i18n'
 import { prepareStoreView, storeCodeFromRoute, currentStoreView, localizedRoute } from '@vue-storefront/core/lib/multistore'
 import { onNetworkStatusChange } from '@vue-storefront/core/modules/offline-order/helpers/onNetworkStatusChange'

core/compatibility/components/Breadcrumbs.js

@@ -8,7 +8,7 @@ export default {
     },
     activeRoute: {
       type: String,
-      required: true
+      default: ''
     }
   }
 }