Skip to content

Conversation

@omnom62
Copy link
Contributor

@omnom62 omnom62 commented Oct 20, 2025

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Migration from an old Vyatta component to vyos-1x, please link to related PR inside obsoleted component
  • Other (please describe):

Related Task(s)

Related PR(s)

Component(s) name

Proposed changes

How to test

Test results

  • Sanity tests passed
  • Unit tests passed

Tested against VyOS versions:

  • 1.3.8
  • 1.4-rolling-202201010100

Checklist:

  • I have read the CONTRIBUTING document
  • I have linked this PR to one or more Phabricator Task(s)
  • I have run the ansible sanity and unit tests
  • My commit headlines contain a valid Task id
  • My change requires a change to the documentation
  • I have updated the documentation accordingly
  • I have added unit tests to cover my changes
  • I have added a file to changelogs/fragments to describe the changes

@omnom62 omnom62 requested a review from a team as a code owner October 20, 2025 10:44
@omnom62 omnom62 changed the title T6820 VRRP support T6820 VRRP module Oct 20, 2025
@gaige
Copy link
Contributor

gaige commented Oct 21, 2025

@omnom62 Can you update the PR template, it seems rather empty.

@gaige
Copy link
Contributor

gaige commented Oct 21, 2025

RST file is missing as well, which is odd because that should be auto-created. Sanity checks are failing as well. This seem s not quite ready, should it be in Draft?

@omnom62 omnom62 marked this pull request as draft October 21, 2025 09:00
@omnom62
Copy link
Contributor Author

omnom62 commented Oct 21, 2025

RST file is missing as well, which is odd because that should be auto-created. Sanity checks are failing as well. This seem s not quite ready, should it be in Draft?

My bad, @gaige , yes, indeed, this is still in Draft - finishing rm_templates section

@omnom62 omnom62 changed the title T6820 VRRP module WIP T6820 VRRP module Oct 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants