Clean up and modularize JavaScript (particularly MapLibre)

[walkerke]

I have had so much fun writing this package. It's been amazing to see my dream R package become a reality.

However, as I have added feature upon feature, the JavaScript files have become bloated, with several thousands of lines of (sometimes duplicated) code among them.

The MapLibre code in particular has some vestigial hacks from me trying to debug the perplexing basemap switcher issue.

I want to leave this here (as everything "works") but I think it would be helpful for longer-term maintenance of the package to modularize and clean up the JavaScript.

I'm open to suggestions for users who are experienced maintaining JS projects.

[ar-puuk]

Hi @walkerke, thanks again for the incredible work on mapgl. It’s been such a helpful tool.

I saw you mentioned the basemap switcher logic was part of the planned JS cleanup/modularization. I was curious if you've had any recent luck untangling that or if it's still proving to be a bit of a puzzle?

No pressure at all on a timeline—I'm just planning out some upcoming project workflows and was wondering if that feature might be on the horizon soon. Thanks for all you do!

[walkerke]

Basemap switching does work with set_style() correctly, though I don't have a "basemap control" in the pipeline for the package. If you set up your own Shiny input that calls set_style() over a proxy object, it should preserve map state correctly.