Skip to content

Conversation

@mohamedamir
Copy link
Contributor

Updates the Digital Credentials API implementation to remove the strict requirement for mediation: 'required'. This change allows navigator.credentials.create() and navigator.credentials.get() to be called without specifying a mediation hint.

This aligns with recent specification changes and improves developer experience.

@mohamedamir
Copy link
Contributor Author

@marcoscaceres We should ideally add tests that requests succeed for different mediation values.
But that's not possible before having proper testing automation support. Do you have other ideas? How can we best track this work?

Maybe I add the tests as part of this PR and we modify them later once we have the webdriver changes are available?

WDYT?

@mohamedamir
Copy link
Contributor Author

@marcoscaceres We should ideally add tests that requests succeed for different mediation values. But that's not possible before having proper testing automation support. Do you have other ideas? How can we best track this work?

Maybe I add the tests as part of this PR and we modify them later once we have the webdriver changes are available?

WDYT?

As per our discussion, we should use the AbortController to abort request and test that no other error is thrown.

@mohamedamir
Copy link
Contributor Author

@marcoscaceres We should ideally add tests that requests succeed for different mediation values. But that's not possible before having proper testing automation support. Do you have other ideas? How can we best track this work?
Maybe I add the tests as part of this PR and we modify them later once we have the webdriver changes are available?
WDYT?

As per our discussion, we should use the AbortController to abort request and test that no other error is thrown.

@marcoscaceres I have updated the tests as per our discussion!
Could you please take a look?

Thank you!

@mohamedamir mohamedamir merged commit a16d4de into web-platform-tests:master Nov 27, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants