Skip to content

Remove calls to deprecated CRM_Utils_Array::value #84

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
colemanw wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Remove calls to deprecated CRM_Utils_Array::value #84

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 11 additions & 11 deletions CRM/SimpleDonate/Form/SimpleDonationSetting.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ function setDefaultValues() {
'domain_id' => $domainID,
'return' => "simple_donation_page",
));
$this->_defaults['simpleDonation'] = CRM_Utils_Array::value('simple_donation_page', $settings['values'][$domainID]);
$this->_defaults['simpleDonation'] = $settings['values'][$domainID]['simple_donation_page'] ?? NULL;
$this->_defaults['ziptastic'] = CRM_Core_BAO_Setting::getItem('Simple Donation', 'ziptastic_enable');
return $this->_defaults;
}
Expand Down Expand Up @@ -115,7 +115,7 @@ public function postProcess() {

$zipParams = array(
'domain_id' => CRM_Core_Config::domainID(),
'ziptastic_enable' => CRM_Utils_Array::value('ziptastic', $params) ? 1 : 0,
'ziptastic_enable' => $params['ziptastic'] ?? NULL ? 1 : 0,
);
$result = civicrm_api3('setting', 'create', $zipParams);
if (CRM_Utils_Array::value('is_error', $result, FALSE)) {
Expand All @@ -127,7 +127,7 @@ public function postProcess() {
static public function transactDonation() {
$session = CRM_Core_Session::singleton();
$contactID = $session->get('userID');
$params = CRM_Utils_Array::value('params', $_POST);
$params = $_POST['params'] ?? NULL;

$params['cardExpiry'] = str_replace('20', '', $params['cardExpiry']);
//check credit card expiry validation
Expand All @@ -147,9 +147,9 @@ static public function transactDonation() {
exit;
}
}
$params['amount'] = CRM_Utils_Array::value('amount', $_POST);
$creditInfo = CRM_Utils_Array::value('creditInfo', $_POST);
$isTest = CRM_Utils_Array::value('isTest', $_POST);
$params['amount'] = $_POST['amount'] ?? NULL;
$creditInfo = $_POST['creditInfo'] ?? NULL;
$isTest = $_POST['isTest'] ?? NULL;
//create Contact, billing address
$userInfo = explode(' ', $params['user']);
$params['first_name'] = $userInfo[0];
Expand Down Expand Up @@ -181,7 +181,7 @@ static public function transactDonation() {
$dedupeParams['check_permission'] = FALSE;
$ids = CRM_Dedupe_Finder::dupesByParams($dedupeParams, 'Individual');
// if we find more than one contact, use the first one
$contactID = CRM_Utils_Array::value(0, $ids);
$contactID = $ids[0] ?? NULL;
if (!$contactID) {
$cont = civicrm_api3('Contact', 'create', $cParam);
$contactID = $cont['id'];
Expand Down Expand Up @@ -224,7 +224,7 @@ static public function createSimpleContribution($contactID, $params, $isTest, $c
'id' => $donatePageID,
));
$contributionparams = array();
$isrecur = CRM_Utils_Array::value('recur', $params);
$isrecur = $params['recur'] ?? NULL;
$contributionparams = array(
"billing_first_name" => $params['first_name'],
"first_name" => $params['first_name'],
Expand All @@ -245,8 +245,8 @@ static public function createSimpleContribution($contactID, $params, $isTest, $c
"postal_code" => $params['zip'],
"email" => $params['email'],
"contribution_page_id" => $donatePageID,
"payment_processor_id" => CRM_Utils_Array::value('payment_processor', $params),
"payment_processor" => CRM_Utils_Array::value('payment_processor', $params),
"payment_processor_id" => $params['payment_processor'] ?? NULL,
"payment_processor" => $params['payment_processor'] ?? NULL,
"is_test" => $isTest,
"is_pay_later" => $params['is_pay_later'],
"total_amount"=> $params['amount'],
Expand Down Expand Up @@ -316,7 +316,7 @@ static public function createSimpleContribution($contactID, $params, $isTest, $c
$recurParams['start_date'] = $recurParams['create_date'] = $recurParams['modified_date'] = date('YmdHis');
$recurParams['invoice_id'] = $recurParams['trxn_id'] = md5(uniqid(rand(), TRUE));
$recurParams['contribution_status_id'] = CRM_Core_PseudoConstant::getKey('CRM_Contribute_BAO_Contribution', 'contribution_status_id', 'Pending');
$recurParams['payment_processor_id'] = CRM_Utils_Array::value('payment_processor_id', $contributionparams);
$recurParams['payment_processor_id'] = $contributionparams['payment_processor_id'] ?? NULL;
$recurParams['is_email_receipt'] = 1;
//create recurring contribution record
$recurring = CRM_Contribute_BAO_ContributionRecur::add($recurParams);
Expand Down