test: createBatchSheduler.waitAsRateLimit & getBatchSize

Author: iyarsius

src/utils/promise/createBatchScheduler.test.ts

@@ -117,13 +117,13 @@ test('args: wait', async () => {
   expect(x10).toEqual([10, [8, 9, 10]])
 })
 
-test('args: shouldSplitBatch', async () => {
+test('args: getBatchSize', async () => {
   const fn = vi.fn()
   const { schedule } = createBatchScheduler({
     id: uid(),
     // biome-ignore lint/style/noCommaOperator:
     fn: async (args: number[]) => (fn(), args),
-    shouldSplitBatch: (args) => args.length > 3,
+    getBatchSize: () => 3,
   })
 
   const p = []
@@ -163,6 +163,47 @@ test('args: shouldSplitBatch', async () => {
   expect(fn).toBeCalledTimes(6)
 })
 
+test('args: waitAsRateLimit', async () => {
+  const date = Date.now()
+
+  const fn = vi.fn()
+  const { schedule } = createBatchScheduler({
+    id: uid(),
+    getBatchSize: () => 3,
+    wait: 500,
+    waitAsRateLimit: true,
+    // biome-ignore lint/style/noCommaOperator:
+    fn: async (args: number[]) => (fn(), args),
+  })
+
+  const p = []
+
+  p.push(schedule(1))
+  p.push(schedule(2))
+  p.push(schedule(3))
+  p.push(schedule(4))
+  p.push(schedule(5))
+  p.push(schedule(6))
+  p.push(schedule(7))
+  p.push(schedule(8))
+  p.push(schedule(9))
+
+  const [x1, x2, x3, x4, x5, x6, x7, x8, x9] = await Promise.all(p)
+
+  expect(x1).toEqual([1, [1, 2, 3]])
+  expect(x2).toEqual([2, [1, 2, 3]])
+  expect(x3).toEqual([3, [1, 2, 3]])
+  expect(x4).toEqual([4, [4, 5, 6]])
+  expect(x5).toEqual([5, [4, 5, 6]])
+  expect(x6).toEqual([6, [4, 5, 6]])
+  expect(x7).toEqual([7, [7, 8, 9]])
+  expect(x8).toEqual([8, [7, 8, 9]])
+  expect(x9).toEqual([9, [7, 8, 9]])
+
+  const elapsed = Date.now() - date
+  expect(elapsed).toBeGreaterThanOrEqual(1500)
+})
+
 describe('behavior', () => {
   test('complex args', async () => {
     const { schedule } = createBatchScheduler({
@@ -188,51 +229,6 @@ describe('behavior', () => {
     ])
   })
 
-  test('complex split batch', async () => {
-    const fn = vi.fn()
-    const { schedule } = createBatchScheduler({
-      id: uid(),
-      wait: 16,
-      // biome-ignore lint/style/noCommaOperator:
-      fn: async (args: string[]) => (fn(), args),
-      shouldSplitBatch: (args) =>
-        args.reduce((acc, x) => acc + x.length, 0) > 20,
-    })
-
-    const p = []
-    p.push(schedule('hello'))
-    p.push(schedule('world'))
-    p.push(schedule('this is me'))
-    p.push(schedule('life should be'))
-    p.push(schedule('fun for everyone'))
-    await wait(1)
-    p.push(schedule('hello world'))
-    p.push(schedule('come and see'))
-    p.push(schedule('come'))
-    p.push(schedule('and'))
-    await wait(16)
-    p.push(schedule('see'))
-    p.push(schedule('smile'))
-    p.push(schedule('just be yourself'))
-    p.push(schedule('be happy'))
-
-    const [x1, x2, x3, x4, x5, x6, x7, x8, x9, x10, x11] = await Promise.all(p)
-
-    expect(x1).toEqual(['hello', ['hello', 'world', 'this is me']])
-    expect(x2).toEqual(['world', ['hello', 'world', 'this is me']])
-    expect(x3).toEqual(['this is me', ['hello', 'world', 'this is me']])
-    expect(x4).toEqual(['life should be', ['life should be']])
-    expect(x5).toEqual(['fun for everyone', ['fun for everyone']])
-    expect(x6).toEqual(['hello world', ['hello world']])
-    expect(x7).toEqual(['come and see', ['come and see', 'come', 'and']])
-    expect(x8).toEqual(['come', ['come and see', 'come', 'and']])
-    expect(x9).toEqual(['and', ['come and see', 'come', 'and']])
-    expect(x10).toEqual(['see', ['see', 'smile']])
-    expect(x11).toEqual(['smile', ['see', 'smile']])
-
-    expect(fn).toBeCalledTimes(8)
-  })
-
   test('throws error', async () => {
     const { schedule } = createBatchScheduler({
       id: uid(),