Navigation API: Inconsistency between spec and tests in #abort-a-navigateevent

[jnjaeschke]

What is the issue with the HTML Standard?

Step 2 of #abort-a-navigateevent signals an abort on the event's abort controller. This is called as part of the failure steps called from #inner-navigate-event-firing. However, when implementing this, the following tests fail, because the abort signal is not listed.

• https://github.com/web-platform-tests/wpt/blob/c05ece9d6f47c4e8ca20c3625a12206fe4208519/navigation-api/ordering-and-transition/navigate-same-document-intercept-reject.html#L46-L47
• https://github.com/web-platform-tests/wpt/blob/c05ece9d6f47c4e8ca20c3625a12206fe4208519/navigation-api/ordering-and-transition/reload-intercept-reject.html#L46-L47

Gecko's old (pre-precommithandler) implementation passed these tests, so I assume that there were refactorings and the tests need to be updated.

cc @noamr

[jnjaeschke]

Looking at the Chrome source code, it seems that the abort step runs if the event's interception state is intercepted.

[noamr]

@natechapin does this make sense?

[jnjaeschke]

Err, what I forgot to mention: This test requires the abort signal (which is how I found out about Chromiums implementation).

[smaug----]

( I can't seem to wonder how the implementations and spec don't match. )

[noamr]

( I can't seem to wonder how the implementations and spec don't match. )

I wasn't involved when this was developed but I remember this being a giant spec PR for months while iterating on the prototype. The navigation API in general is on the more complicated side of recent web APIs so I am not totally surprised that some differences come up alongside the 2nd and 3rd implementation a few years after. Happy to chat about this more at TPAC.

[noamr]

This CL aligns chromium implementation and the tests with the wording of the spec.

[jnjaeschke]

@natechapin please also file a test change proposal because this changes tests which are part of interop-2025.

[noamr]

@natechapin please also file a test change proposal because this changes tests which are part of interop-2025.

web-platform-tests/wpt#55707

[natechapin]

@natechapin please also file a test change proposal because this changes tests which are part of interop-2025.

web-platform-tests/interop#1214