fix(web): use wss:// for HTTPS connections and apply cargo fmt#388
Merged
123vivekr merged 1 commit intowinfunc:mainfrom Oct 16, 2025
Merged
fix(web): use wss:// for HTTPS connections and apply cargo fmt#388123vivekr merged 1 commit intowinfunc:mainfrom
123vivekr merged 1 commit intowinfunc:mainfrom
Conversation
- Fix WebSocket protocol to use wss:// for HTTPS (ngrok) and ws:// for HTTP (localhost) - This resolves the issue where Send button doesn't work when accessed via ngrok - Apply cargo fmt to fix Rust code formatting issues 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
Contributor
Author
|
I have manually tested, localhost (http) and ngrok (https). #216 was tested only with localhost, but now that I want to use it more - it failed via ngrok; hence this fix. |
Member
|
Thanks a lot @eisbaw |
Member
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix WebSocket connection for HTTPS/ngrok access by automatically detecting the page protocol and using the appropriate WebSocket protocol.
See also #216
Changes
wss://for HTTPS connections (e.g., ngrok) andws://for HTTP connections (localhost)cargo fmtto fix code style issues across multiple filesProblem
When accessing the web UI via ngrok (HTTPS), the Send button didn't work because browsers block insecure WebSocket connections (
ws://) from secure pages.Solution
Modified
src/lib/apiAdapter.tsto detect the page protocol and construct the WebSocket URL accordingly:Test plan
🤖 Generated with Claude Code