From f57f8852d971bf81c29b04931c6caacc787c227c Mon Sep 17 00:00:00 2001 From: Brian Ebert Date: Wed, 25 Mar 2026 18:25:32 -0700 Subject: [PATCH] Accounts for None result. --- benchmark.py | 6 +++--- src/report_generator.py | 6 ++++-- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/benchmark.py b/benchmark.py index 138a1ac..861be72 100644 --- a/benchmark.py +++ b/benchmark.py @@ -560,10 +560,10 @@ def val_emoji(val): console.print(table) # Show apples-to-apples status - if comp.get("both_validated"): + if comp.get("both_validated") or (single_valid and multi_valid): console.print("\n[green]✅ Apples-to-apples comparison: Both outputs validated successfully[/green]") - elif single_val is not None or multi_val is not None: - console.print("\n[yellow]⚠️ Comparison caveat: Outputs differ in quality (see report for details)[/yellow]") + elif (single_val is not None or multi_val is not None) and single_valid != multi_valid: + console.print("\n[yellow]⚠️ Comparison caveat: Output validation differs between runs (see report for details)[/yellow]") def main(): diff --git a/src/report_generator.py b/src/report_generator.py index 30729b2..a7c5bfd 100644 --- a/src/report_generator.py +++ b/src/report_generator.py @@ -369,8 +369,8 @@ def _generate_postmortem_analysis(self) -> str: report += "\n" # Test count comparison - s_tests = sv.get("test_validation", {}) if sv else {} - m_tests = mv.get("test_validation", {}) if mv else {} + s_tests = (sv.get("test_validation") or {}) if sv else {} + m_tests = (mv.get("test_validation") or {}) if mv else {} s_passed = s_tests.get("passed", 0) m_passed = m_tests.get("passed", 0) @@ -796,6 +796,8 @@ def fmt_bytes(s): return report def save_report(self): + self._calculate_comparison() + json_file = self.output_dir / "benchmark_report.json" with open(json_file, "w") as f: json.dump(self.report_data, f, indent=2, default=str)