-
Notifications
You must be signed in to change notification settings - Fork 232
Updating the renderer to 1.21.10 #683
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Draft
temotskipa
wants to merge
29
commits into
xCollateral:dev
Choose a base branch
from
temotskipa:dev
base: dev
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
+15,444
−11,275
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…cture, including a constructor, a builder class, and placeholder methods. This completes the first step of the plan. I have created the three placeholder shader files: `raygen.rgen`, `miss.rmiss`, and `closesthit.rchit`, and placed them in the correct directory. This completes the second step of the plan. I have modified the `SPIRVUtils.java` file to include the new ray tracing shader types in the `ShaderKind` enum. This completes the third step of the plan. I have updated the `PipelineManager` to handle the new `RayTracingPipeline`, including adding a field for it, a method to create it, and updating the cleanup method. This completes the fourth step of the plan. This involved adding the `doRayTracing` and `bindRayTracingPipeline` methods to `Renderer.java` and calling `doRayTracing` from the `endFrame` method. This completes the fifth step of the plan. I have added the `enableRayTracing` option to the `Config` class and used it to conditionally execute the ray tracing code in `Renderer.java`. This completes the sixth step of the plan.
This commit resolves several compilation errors that were causing the Gradle build to fail. The following changes were made: - Removed a duplicated package declaration in `src/main/java/net/vulkanmod/vulkan/shader/RayTracingPipeline.java`. - Corrected the import path for the `Buffer` class. - Added missing static imports for Vulkan API symbols from VK11, KHRBufferDeviceAddress, and VK12. - Updated the cleanup method call from `free()` to `scheduleFree()` to match the `Buffer` class API. - Declared the missing `sbtStride` field.
Fix Gradle build errors in RayTracingPipeline.java
Saving the current state of the rendering refactor due to persistent tool service issues. This commit is not expected to build successfully but captures the changes made so far.
WIP: Save rendering refactor state
…ation Fix ray tracing shader binding table setup
…-dependencies Update Fabric dependencies for Minecraft 1.21.10
…-pipeline Update renderer integration for new pipeline API
|
It is still WIP, so I published it as a draft PR for now. If anyone has any suggestions or better yet, code, feel free to contribute. |
…er clarity and consistency.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates the mod and refactors the renderer for 1.21.10 compatibility and prepares it for future enhancements like RT. It also includes changes to the README, refactors the mod to use Mojang mappings (due to better rendering class mappings), adds AGENTS.md and other stuff.