Skip to content

CP-52937 Update tapdisk/cbt-util/vhd-util to use base64 #761

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

CP-52937 Update tapdisk/cbt-util/vhd-util to use base64 #761

wants to merge 1 commit into from

Conversation

@LunfanZhang
Copy link
Contributor

  • Encode the key to avoid passing binary data directly to the tap-ctl
  • Decode the result when vhd-util read -B -E or cbt-util get -b -E
  • Update the testcase

BST: 219165
PR for binary tools: xapi-project/blktap#426

@LunfanZhang
CP-52937 Update tapdisk/cbt-util/vhd-util to use base64
fd88b15 
Signed-off-by: Lunfan Zhang[Lunfan.Zhang] <Lunfan.Zhang@cloud.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@MarkSymsCtx MarkSymsCtx Awaiting requested review from MarkSymsCtx

@TimSmithCtx TimSmithCtx Awaiting requested review from TimSmithCtx

@KevinLCtx KevinLCtx Awaiting requested review from KevinLCtx

At least 2 approving reviews are required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@LunfanZhang