Skip to content

Conversation

@klmp200
Copy link

@klmp200 klmp200 commented Oct 28, 2025

Explicit error message pointing to missing vdi_type on SRMetadata update Add a distinction for unpacking corrupted empty metadata headers for easier diagnostic

@MarkSymsCtx
Copy link
Contributor

These changes are probably fine but currently fail on coverage grounds

-------------
Diff Coverage
Diff: github/master...HEAD, staged and unstaged changes
-------------
libs/sm/drivers/LVHDSR.py (66.7%): Missing lines 244
libs/sm/srmetadata.py (50.0%): Missing lines 183,186-187
-------------
Total:   9 lines
Missing: 4 lines
Coverage: 55%
-------------

Please add suitable unit tests to exercise this functionality to ensure that it remain functional going forward. More than 80% coverage of new code will be required and where possible full coverage of code and important conditions.

@klmp200 klmp200 force-pushed the improve-error-with-bad-mgt-upstream branch from 1db1863 to f44f04a Compare October 29, 2025 09:41
@klmp200
Copy link
Author

klmp200 commented Oct 29, 2025

These changes are probably fine but currently fail on coverage grounds

-------------
Diff Coverage
Diff: github/master...HEAD, staged and unstaged changes
-------------
libs/sm/drivers/LVHDSR.py (66.7%): Missing lines 244
libs/sm/srmetadata.py (50.0%): Missing lines 183,186-187
-------------
Total:   9 lines
Missing: 4 lines
Coverage: 55%
-------------

Please add suitable unit tests to exercise this functionality to ensure that it remain functional going forward. More than 80% coverage of new code will be required and where possible full coverage of code and important conditions.

You're right, I should have done it in the first place.
It's all good now :)

@klmp200 klmp200 force-pushed the improve-error-with-bad-mgt-upstream branch from f44f04a to 5ba8eb9 Compare October 29, 2025 09:44
Explicit error message pointing to missing vdi_type on SRMetadata update
Add a distinction for unpacking corrupted empty metadata headers for easier diagnostic

Signed-off-by: Antoine Bartuccio <antoine.bartuccio@vates.tech>
@klmp200 klmp200 force-pushed the improve-error-with-bad-mgt-upstream branch from 5ba8eb9 to f106d1a Compare October 29, 2025 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants