Skip to content

Conversation

@bill1600
Copy link
Contributor

handle jwt expiration
and tests.

@bill1600 bill1600 requested a review from schmidtw April 19, 2018 17:21
@codecov-io
Copy link

codecov-io commented Apr 19, 2018

Codecov Report

Merging #189 into master will increase coverage by 0.15%.
The diff coverage is 95.78%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #189      +/-   ##
==========================================
+ Coverage   88.27%   88.42%   +0.15%     
==========================================
  Files          41       41              
  Lines        4426     4518      +92     
  Branches      358      361       +3     
==========================================
+ Hits         3907     3995      +88     
- Misses        188      189       +1     
- Partials      331      334       +3
Impacted Files Coverage Δ
src/connection.c 73.61% <ø> (ø) ⬆️
tests/test_conn_interface.c 95.91% <100%> (+1.5%) ⬆️
src/token.c 64.55% <78.57%> (+0.77%) ⬆️
src/conn_interface.c 88.52% <91.66%> (+0.76%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9421a3d...5325007. Read the comment docs.

src/connection.c Outdated

#define HTTP_CUSTOM_HEADER_COUNT 5
#define INITIAL_CJWT_RETRY -2
#define Parodus_Print printf
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be removed.

src/connection.c Outdated
if(allow_insecure <= 0)
{
ParodusPrint("secure true\n");
Parodus_Print("secure true\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be reverted.

src/connection.c Outdated
else
{
ParodusPrint("secure false\n");
Parodus_Print("secure false\n");
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change should be reverted.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants