From e0f2dfb81c9e3085e22b8bbda317cdb0ee9b3d4a Mon Sep 17 00:00:00 2001 From: Yahya Hassani Date: Wed, 25 Jan 2023 10:26:32 +0100 Subject: [PATCH 1/3] Change state to be immutable --- .../src/main/java/com/example/ui/common/BaseViewModel.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/ui/common/src/main/java/com/example/ui/common/BaseViewModel.kt b/ui/common/src/main/java/com/example/ui/common/BaseViewModel.kt index a693aef..e5bba49 100644 --- a/ui/common/src/main/java/com/example/ui/common/BaseViewModel.kt +++ b/ui/common/src/main/java/com/example/ui/common/BaseViewModel.kt @@ -11,8 +11,8 @@ import androidx.lifecycle.ViewModel */ abstract class BaseViewModel(initialState: T) : ViewModel() { - private var internalSate: MutableState = mutableStateOf(initialState) - var state: State = internalSate + private val internalSate: MutableState = mutableStateOf(initialState) + val state: State = internalSate abstract fun onEvent(event: E) From fd598314f82daed9e778a4b274d4519d69110058 Mon Sep 17 00:00:00 2001 From: Yahya Hassani Date: Wed, 25 Jan 2023 10:28:33 +0100 Subject: [PATCH 2/3] Decrease requests timeout --- .../main/java/com/example/data/common/api/di/NetworkModule.kt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/data/common/src/main/java/com/example/data/common/api/di/NetworkModule.kt b/data/common/src/main/java/com/example/data/common/api/di/NetworkModule.kt index 2d18028..ff66a27 100644 --- a/data/common/src/main/java/com/example/data/common/api/di/NetworkModule.kt +++ b/data/common/src/main/java/com/example/data/common/api/di/NetworkModule.kt @@ -33,8 +33,8 @@ interface NetworkModule { val logging = HttpLoggingInterceptor() logging.setLevel(HttpLoggingInterceptor.Level.BODY) OkHttpClient.Builder() - .readTimeout(60, TimeUnit.SECONDS) - .writeTimeout(60, TimeUnit.SECONDS) + .readTimeout(15, TimeUnit.SECONDS) + .writeTimeout(15, TimeUnit.SECONDS) .addInterceptor(logging) .build() } else OkHttpClient.Builder().build() From 4b55916604190fd79c3d8b5f2f4d26d7dde2f331 Mon Sep 17 00:00:00 2001 From: Yahya Hassani Date: Wed, 25 Jan 2023 10:29:46 +0100 Subject: [PATCH 3/3] Remove unnecessary tag --- app/src/main/AndroidManifest.xml | 4 ---- 1 file changed, 4 deletions(-) diff --git a/app/src/main/AndroidManifest.xml b/app/src/main/AndroidManifest.xml index 4fc516a..ea4c43f 100644 --- a/app/src/main/AndroidManifest.xml +++ b/app/src/main/AndroidManifest.xml @@ -23,10 +23,6 @@ - -