Feedback on setup instructions

[devth]

A few things I saw during install.

shadow-cljs warns on startup

± npx shadow-cljs watch :dashboard
npx: installed 99 in 3.974s
------------------------------------------------------------------------------
   WARNING: shadow-cljs not installed in project.
   See https://shadow-cljs.github.io/docs/UsersGuide.html#project-install
------------------------------------------------------------------------------

but the project-install section doesn't exist anymore in the docs. Maybe outdated warning.

warning about missing react

The required namespace "react" is not available, it was required by "day8/re_frame_10x/inlined_deps/reagent/v0v10v0/reagent/core.cljs".
The namespace was provided via :foreign-libs which is not supported.
Please refer to https://shadow-cljs.github.io/docs/UsersGuide.html#cljsjs for more information.
You may just need to run:
  npm install react

Don't think we should be relying on globally-available dependencies. The build tool should resolve this for us.

lein integration?

Is there a way to encapsulate all the shadow-cljs stuff in leiningen? It's nice to have a single build tool that does everything. Not sure if this is normal with shadow-cljs - I've never used shadow. Or maybe I'm thinking about it wrong. I did see the lein specific docs. Is that an alternative to building with shadow-cljs?

dev/dev.clj usage

If I start a lein repl it defaults to user namespace. How do we load dev? Should dev exist under src??

[kaffein]

I have started refactoring on this side. We now have a few leiningen aliases to encapsulate all shadow-cljs interactions. So from now on, we can just use those as entrypoints to the build process :

• lein watch starts a shadow-cljs watch process
• lein compile-cljs allows to compile the project
• lein release-cljs compiles the project for production and outputs a minified version of the compiled code for each module
• lein cljs-repl starts a clojurescript repl

those aliases also include a phase for installing the npm dependencies so the issue related to missing npm dependencies is now solved.

regarding the dev/dev.clj usage, it is not included in the src folder because it is not part of the frontend per say, it is only there to allow programmatic interaction with the underlying shadow-cljs server instance etc. and if I include it in the src folder then when we start the shadow-cljs server (via a watch or explicitly), it complains since it is a clj file.

I have also updated the README file accordingly, I will push it soon (probably tomorrow). I am making some last modifications but feel free to let me know if that sounds good for you or not.

[devth]

Sounds great @kaffein! Nice work.