Don't mock what you don't own (#66)

* Do not rely on mock for Doctrine manager nor registry

* Do not rely on mock for event dispatcher

* Do not rely on mock for symfony normalizer nor denormalizer

* Remove phpspec/prophecy-phpunit dev dependency from packages that are no longer using it

Author: yann-eugone

tests/RunJobCommandTest.php

@@ -8,6 +8,7 @@
 use PHPUnit\Framework\TestCase;
 use Prophecy\Argument;
 use Prophecy\PhpUnit\ProphecyTrait;
+use Prophecy\Prophecy\ObjectProphecy;
 use Psr\EventDispatcher\EventDispatcherInterface;
 use Symfony\Component\Console\Output\OutputInterface;
 use Symfony\Component\Console\Tester\CommandTester;
@@ -29,10 +30,13 @@ class RunJobCommandTest extends TestCase
 
     private const JOBNAME = 'testing';
 
+    private JobInterface|ObjectProphecy $job;
+    private JobExecutionAccessor $accessor;
+    private JobExecutor $executor;
+
     protected function setUp(): void
     {
         $this->job = $this->prophesize(JobInterface::class);
-        $this->dispatcher = $this->prophesize(EventDispatcherInterface::class);
 
         $this->accessor = new JobExecutionAccessor(
             new JobExecutionFactory(new UniqidJobExecutionIdGenerator()),
@@ -41,24 +45,10 @@ protected function setUp(): void
         $this->executor = new JobExecutor(
             JobRegistry::fromJobArray([self::JOBNAME => $this->job->reveal()]),
             new InMemoryJobExecutionStorage(),
-            $this->dispatcher->reveal()
+            null
         );
     }
 
-    private function execute(string $configuration = null, int $verbosity = OutputInterface::VERBOSITY_NORMAL): array
-    {
-        $options = ['verbosity' => $verbosity];
-        $input = ['job' => self::JOBNAME];
-        if ($configuration !== null) {
-            $input['configuration'] = $configuration;
-        }
-
-        $tester = new CommandTester(new RunJobCommand($this->accessor, $this->executor));
-        $tester->execute($input, $options);
-
-        return [$tester->getStatusCode(), $tester->getDisplay()];
-    }
-
     public function testRunWithMalformedConfiguration(): void
     {
         $this->expectException(JsonException::class);
@@ -164,4 +154,18 @@ public function verbosity(): \Generator
         yield 'very verbose' => [OutputInterface::VERBOSITY_VERY_VERBOSE];
         yield 'debug' => [OutputInterface::VERBOSITY_DEBUG];
     }
+
+    private function execute(string $configuration = null, int $verbosity = OutputInterface::VERBOSITY_NORMAL): array
+    {
+        $options = ['verbosity' => $verbosity];
+        $input = ['job' => self::JOBNAME];
+        if ($configuration !== null) {
+            $input['configuration'] = $configuration;
+        }
+
+        $tester = new CommandTester(new RunJobCommand($this->accessor, $this->executor));
+        $tester->execute($input, $options);
+
+        return [$tester->getStatusCode(), $tester->getDisplay()];
+    }
 }