internal/config/config.go: Do not save config when LAB_CORE_TOKEN is used

prarit · prarit · commit 31436ce09d53 · 2023-07-13T13:43:50.000-04:00
@doronbehar reported a bug in lab where they specified LAB_CORE_TOKEN on the command line and then value was saved in the config file. Using LAB_CORE_TOKEN or LAB_CORE_HOST should not overwrite the config file. Do not save the config when LAB_CORE_TOKEN or LAB_CORE_HOST is specified. Signed-off-by: Prarit Bhargava <prarit@redhat.com>
diff --git a/internal/config/config.go b/internal/config/config.go
@@ -73,9 +73,12 @@ func New(confpath string, r io.Reader) error {
 		MainConfig.Set("core.load_token", loadToken)
 	}
 
-	if err := MainConfig.WriteConfigAs(confpath); err != nil {
-		return err
+	if strings.TrimSpace(os.Getenv("LAB_CORE_TOKEN")) == "" && strings.TrimSpace(os.Getenv("LAB_CORE_HOST")) == "" {
+		if err := MainConfig.WriteConfigAs(confpath); err != nil {
+			return err
+		}
 	}
+
 	fmt.Printf("\nConfig saved to %s\n", confpath)
 	err = MainConfig.ReadInConfig()
 	if err != nil {

Original file line number	Diff line number	Diff line change
`@@ -73,9 +73,12 @@ func New(confpath string, r io.Reader) error {`
`73`	`73`	`MainConfig.Set("core.load_token", loadToken)`
`74`	`74`	`}`
`75`	`75`
`76`		`- if err := MainConfig.WriteConfigAs(confpath); err != nil {`
`77`		`- return err`
	`76`	`+ if strings.TrimSpace(os.Getenv("LAB_CORE_TOKEN")) == "" && strings.TrimSpace(os.Getenv("LAB_CORE_HOST")) == "" {`
	`77`	`+ if err := MainConfig.WriteConfigAs(confpath); err != nil {`
	`78`	`+ return err`
	`79`	`+ }`
`78`	`80`	`}`
	`81`	`+`
`79`	`82`	`fmt.Printf("\nConfig saved to %s\n", confpath)`
`80`	`83`	`err = MainConfig.ReadInConfig()`
`81`	`84`	`if err != nil {`