Skip to content

Conversation

@stefannica
Copy link
Contributor

@stefannica stefannica commented Oct 29, 2025

Describe changes

We currently only support the token authentication method for the Hashicorp Vault secrets store. This authentication method is unusable in production because tokens are usually set to expire after a short time and managing their rotation is painful.

This PR adds a few more authentication method options and also implements automatic token refresh / re-login upon expiration:

Implements: #4092

Pre-requisites

Please ensure you have done the following:

  • I have read the CONTRIBUTING.md document.
  • I have added tests to cover my changes.
  • I have based my new branch on develop and the open PR is targeting develop. If your branch wasn't based on develop read Contribution guide on rebasing branch to develop.
  • IMPORTANT: I made sure that my changes are reflected properly in the following resources:
    • ZenML Docs
    • Dashboard: Needs to be communicated to the frontend team.
    • Templates: Might need adjustments (that are not reflected in the template tests) in case of non-breaking changes and deprecations.
    • Projects: Depending on the version dependencies, different projects might get affected.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@github-actions github-actions bot added internal To filter out internal PRs and issues enhancement New feature or request labels Oct 29, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

✅ No broken links found!

@github-actions
Copy link
Contributor

github-actions bot commented Oct 29, 2025

Documentation Link Check Results

Absolute links check failed
There are broken absolute links in the documentation. See workflow logs for details
Relative links check passed
Last checked: 2025-10-30 08:30:25 UTC

@stefannica stefannica merged commit 8e14213 into develop Oct 30, 2025
71 of 79 checks passed
@stefannica stefannica deleted the feature/hvac-secrets-store-auth-methods branch October 30, 2025 12:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

enhancement New feature or request internal To filter out internal PRs and issues run-slow-ci

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants