prepare.sh: cleaning

Author: stacyharper

script/prepare.sh

@@ -1,17 +1,21 @@
 #!/bin/sh -e
 
-php_logs() {
-	conf_file="/usr/local/etc/php-fpm.d/www.conf"
+html_dir="/var/www/html"
 
-	log_dir="/var/log/php"
-	access_log_file="${log_dir}/access.log"
-	error_log_file="${log_dir}/error.log"
+www_folder() {
+	mkdir -p "$1"
+	chown -R www-data "$1"
+}
 
-	mkdir -p "${log_dir}" \
-		&& touch "${access_log_file}" \
-		&& touch "${error_log_file}"
+www_file() {
+	touch "$1"
+	chown www-data "$1"
+}
 
-	chown -R www-data "${log_dir}"
+php_logs() {
+	www_folder "/var/log/php"
+	www_file "/var/log/php/access.log"
+	www_file "/var/log/php/error.log"
 
 	# The "c" supplementary letter is needed because the first letter will be cut at replacement.
 	sed -i \
@@ -23,15 +27,11 @@ php_logs() {
 		-e '/^;php_admin_value\[error_log\]/cphp_admin_value[error_log] = /var/log/php/error.log' \
 		-e '/^;php_admin_flag\[log_errors\]/cphp_admin_flag[log_errors] = on' \
 		-e '/^;clear_env/cclear_env = no' \
-		"${conf_file}"
+		"/usr/local/etc/php-fpm.d/www.conf"
 }
 
 symfony_logs() {
-	html_dir="/var/www/html"
-	var_dir="${html_dir}/var"
-
-	mkdir -p "${var_dir}"
-	chown -R www-data "${var_dir}"
+	www_folder "${html_dir}/var"
 }
 
 php_logs