Use github-slugger in place of slug #373
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When adding a new changelog fragment, uv [1] is required to be installed, but this is not mentioned in the document. [1]: https://github.com/astral-sh/uv
Author
|
I learned that in the cargo-toml-vs-cargo-lock docs that in general Cargo.lock should be tracked, so I am reverting adding it to .gitignore here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As explained in #370, if there are periods used in the heading and it is referenced, then obsidian-export generates invalid links.
Added gfm-heading-ids-compliance test to reproduce the issue in #370.
Cargo.lock is also added to .gitignore as it is autogenerated.
Closes #370.
This passes all pre-commit hook checks.
Please let me know if there is a use-case for using slug that I may be missing. Replacing it with github-slugger passes all tests, as is.
You can find my notes for this here.