[EXTERNAL] fix: clarify set-internal-vars expected output, remove misleading commas#3138
Open
e-aub wants to merge 1 commit into01-edu:masterfrom
Open
[EXTERNAL] fix: clarify set-internal-vars expected output, remove misleading commas#3138e-aub wants to merge 1 commit into01-edu:masterfrom
e-aub wants to merge 1 commit into01-edu:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why?
The expected output in the exercise documentation was misleading: it showed the array elements with commas
one, two, three, four, fivewhile the actual test expects them to be space-separatedone two three four five. This change clarifies the expected output to prevent confusion when implementing the script.Solution Overview
Updated the instructions and expected output for
set-internal-vars.shto remove commas between array elements. The script now clearly indicates that the array should be printed as space-separated values, matching the automated test expectations.Implementation Details
Build Images