-
Notifications
You must be signed in to change notification settings - Fork 0
142-linked-list-cycle-II #10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
05ryt31
wants to merge
2
commits into
main
Choose a base branch
from
feat/142
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,39 @@ | ||
| ## step1で考えたこと | ||
| 前回の問題に、Cycleがあった場合にその地点のIndexを返す処理が増やされただけ | ||
|
|
||
| どうやってIndexを追うか => 何か追加で変数が必要? | ||
|
|
||
| slow == fastとなった後に何か行う | ||
|
|
||
| slowを追っていって、同じ数字が2回現れたNodeがCycleの開始地点と見做せる? | ||
|
|
||
| => 同じ数字がNodeに二つあった時に壊れる? | ||
|
|
||
| そもそもListじゃないからIndexをどう追うか? | ||
|
|
||
| ## step2 | ||
| 自分が書いたコードを貼って解説をGPTにしてもらったところ、問題文の読み間違えに気づいた。 | ||
|
|
||
| Indexを返す必要はなかった。 | ||
|
|
||
| elseの位置が違う。Noneを返すのは、slowとfastが出会わなかった時 | ||
|
|
||
| whileの条件もisではなく、is not | ||
|
|
||
| isだと最初の時点でTrueになってしまう | ||
|
|
||
| ## step3 | ||
|
|
||
| ### Linked List で is を使う理由 | ||
|
|
||
| Cycle II で知りたいのは | ||
|
|
||
| 「同じ値のノード」ではなく | ||
|
|
||
| 「同じノード(同じメモリ上のノード)」に到達したか | ||
|
|
||
| なので is が正解です。 | ||
|
|
||
| 値が同じノードが2つあっても、それは別ノード | ||
|
|
||
| 開始点は「特定の1ノード」なので同一性で判定する | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,25 @@ | ||
| # 動かないコード | ||
|
|
||
| # Definition for singly-linked list. | ||
| # class ListNode: | ||
| # def __init__(self, x): | ||
| # self.val = x | ||
| # self.next = None | ||
|
|
||
| class Solution: | ||
| def detectCycle(self, head: Optional[ListNode]) -> Optional[ListNode]: | ||
| slow = head | ||
| fast = head | ||
| visited = [] | ||
| visited.append(head) | ||
|
|
||
| while fast and fast.next: | ||
| slow = slow.next | ||
| fast = fast.next.next | ||
| visited.append(slow) | ||
|
|
||
| if slow == fast: | ||
| if slow in visited: | ||
| return | ||
|
|
||
| return None |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,28 @@ | ||
| # 動かないコード | ||
|
|
||
| # Definition for singly-linked list. | ||
| # class ListNode: | ||
| # def __init__(self, x): | ||
| # self.val = x | ||
| # self.next = None | ||
|
|
||
| class Solution: | ||
| def detectCycle(self, head: Optional[ListNode]) -> Optional[ListNode]: | ||
| slow = head | ||
| fast = head | ||
|
|
||
| while fast and fast.next: | ||
| slow = slow.next | ||
| fast = fast.next.next | ||
|
|
||
| if slow is fast: | ||
| break | ||
|
|
||
| else: | ||
| return None | ||
|
|
||
| node = head | ||
| while node is slow: | ||
| node = node.next | ||
| slow = slow.next | ||
| return node |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,26 @@ | ||
| # Definition for singly-linked list. | ||
| # class ListNode: | ||
| # def __init__(self, x): | ||
| # self.val = x | ||
| # self.next = None | ||
|
|
||
| class Solution: | ||
| def detectCycle(self, head: Optional[ListNode]) -> Optional[ListNode]: | ||
| slow = head | ||
| fast = head | ||
|
|
||
| while fast and fast.next: | ||
| slow = slow.next | ||
| fast = fast.next.next | ||
|
|
||
| if slow == fast: | ||
| break | ||
| else: return None | ||
|
|
||
| entry = head | ||
|
|
||
| while entry is not slow: | ||
| entry = entry.next | ||
| slow = slow.next | ||
|
|
||
| return entry |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
このあたりの整え方を見ておいてください。
あ、私のしているコメントを GPT に放り込んでどう思うかなどを聞くのもいいです。
https://docs.google.com/document/d/11HV35ADPo9QxJOpJQ24FcZvtvioli770WWdZZDaLOfg/edit?tab=t.0#heading=h.9kpbwslvv3yv