fix: replace panic with error return in TdxQuote NVIDIA env check#381
Open
sylvaincormier wants to merge 1 commit into0gfoundation:mainfrom
Open
fix: replace panic with error return in TdxQuote NVIDIA env check#381sylvaincormier wants to merge 1 commit into0gfoundation:mainfrom
sylvaincormier wants to merge 1 commit into0gfoundation:mainfrom
Conversation
The CheckPythonEnv call for NVIDIA trust packages uses panic(err) on failure. This crashes the entire broker process when the Python environment is misconfigured, instead of returning an error to the caller. Replace with proper error return consistent with the rest of the function.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
In
api/common/tee/phala.go:132, theTdxQuotefunction callspanic(err)whenCheckPythonEnvfails for NVIDIA trust packages. This crashes the entire broker process instead of returning an error to the caller.Every other error path in this function correctly returns
("", error). This one should too.Changes
panic(err)withreturn "", errors.Wrap(err, "failed to check Python environment for NVIDIA trust packages")Test plan