Fix: Use nullish coalescing operators for better type safety#189
Open
Fix: Use nullish coalescing operators for better type safety#189
Conversation
- Updated root project dependencies via npm update - Resolved all high severity vulnerabilities (previously 1 high) - Reduced total vulnerabilities from 11 to 5 (all low severity) - Updated ESLint, archiver, and other dev dependencies - All workspace packages (CLI, dapp-factory) now clean - Only remaining issues are low severity in mcp-server dependency chain
- replace logical or operators with nullish coalescing for better null/undefined handling - improves code safety by preventing falsy value coercion - addresses eslint prefer-nullish-coalescing warnings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Replace logical OR operators (
||) with nullish coalescing operators (??) in CLI build command for better null/undefined handling.Why
What Changed
CLI/src/commands/build.ts: Fixed 2 instances where||should be??result.error ?? 'Unknown error'result.buildPath ?? 'N/A'Tested