fix: update ci to properly handle npm workspaces#210
Open
Conversation
- Fixed high severity flatted vulnerability (unbounded recursion DoS) - Updated vitest and coverage tools to latest stable versions - Updated linting tools (eslint, typescript-eslint, lint-staged) - Updated @anthropic-ai/sdk from 0.32.1 to latest for CLI - Updated other CLI dependencies (commander, dotenv, inquirer, ora) - All security vulnerabilities resolved
- Remove base-whale-watch from git submodules tracking - Add directory as regular files to fix CI submodule errors - Resolves submodule path not found error in .gitmodules
- Add .gitkeep to maintain directory structure - Complete submodule cleanup for CI stability
- use npm workspace bootstrap instead of individual npm ci commands - ensures proper dependency resolution across all workspaces - fixes typescript compilation and test module resolution errors - uses bootstrap:subprojects script for proper workspace setup this resolves the 'cannot find module' errors in ci for: - @anthropic-ai/sdk - commander, ora, chalk, ajv, dotenv, inquirer - other workspace dependencies
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
All 30 open PRs are failing CI with TypeScript compilation and test errors due to missing module dependencies:
The issue is that the CI workflow was running individual
npm cicommands in each workspace directory instead of using proper npm workspace management.Solution
npm cinpm cinpm run bootstrap:subprojectsfor workspace-specific setupTesting
✅ Submodule path issue fixed in previous commits
✅ Local TypeScript compilation works correctly
✅ Dependencies install properly with workspace approach
This should resolve the CI failures affecting all 30 open PRs.